New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow loading query from inside of query builder #1436
Conversation
🦋 Changeset detectedLatest commit: c3c02cb The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #1436 +/- ##
==========================================
- Coverage 40.60% 40.57% -0.04%
==========================================
Files 1230 1230
Lines 54176 54259 +83
Branches 12261 12283 +22
==========================================
+ Hits 21997 22013 +16
- Misses 32102 32169 +67
Partials 77 77
|
a5c4490
to
0db500a
Compare
2a9d3c5
to
fbcde4e
Compare
a319e10
to
7505fd4
Compare
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/stores/QueryEditorStore.ts
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/stores/QueryEditorStore.ts
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/stores/QueryEditorStore.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small comments. Looks good. Thanks
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
@YannanGao-gs If you already linked this PR to an issue which is already milestoned ( |
c12b519
to
962d98a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't gone through the styling code yet, one comment is that we should add some border to the table (the main display area). Here's my review so far
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/stores/QueryEditorStore.ts
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/stores/QueryEditorStore.ts
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
03859aa
to
f620037
Compare
745f221
to
247b6c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice attempt to approach the problem from scratch, but you haven't accounted for some minor details like debouncing
, let's mimic what we do in EditExistingQuerySetup
and revise this PR. Thanks!
packages/legend-application-query/src/stores/QueryEditorStore.ts
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/stores/query-builder/QueryBuilderConfig.ts
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
packages/legend-application-query/src/components/QueryEditor.tsx
Outdated
Show resolved
Hide resolved
bed9cbb
to
a495542
Compare
a495542
to
c3c02cb
Compare
Summary
Fixes #1435
How did you test this change?
loading queries
Screen.Recording.2022-09-12.at.10.07.00.PM.mov
Screen.Recording.2022-09-12.at.5.17.03.PM.mov
No Query to Review