Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring SDLC instance #147

Merged
merged 4 commits into from
Apr 2, 2021
Merged

Support configuring SDLC instance #147

merged 4 commits into from
Apr 2, 2021

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Apr 1, 2021

Q A
Fixed issues?
Tests added + passed? Yes
Changeset added? Yes
Documentation PR link
Any dependency changes? No

@changeset-bot
Copy link

changeset-bot bot commented Apr 1, 2021

🦋 Changeset detected

Latest commit: e066465

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@finos/legend-studio Patch
@finos/legend-studio-app Patch
@finos/legend-studio-plugin-management Patch
@finos/legend-studio-plugin-tracer-zipkin Patch
@finos/legend-studio-preset-dsl-text Patch
@finos/legend-studio-preset-external-format-json-schema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label Apr 1, 2021
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #147 (e066465) into master (e9d2f4b) will increase coverage by 0.03%.
The diff coverage is 77.50%.

@@            Coverage Diff             @@
##           master     #147      +/-   ##
==========================================
+ Coverage   45.46%   45.50%   +0.03%     
==========================================
  Files         648      648              
  Lines       29675    29707      +32     
  Branches     6705     6651      -54     
==========================================
+ Hits        13491    13517      +26     
- Misses      16137    16143       +6     
  Partials       47       47              
Impacted Files Coverage Δ
...ackages/legend-studio/src/stores/StoreTestUtils.ts 88.46% <ø> (ø)
...ages/legend-studio/src/stores/ApplicationConfig.ts 86.00% <68.75%> (-8.45%) ⬇️
packages/legend-studio/src/components/App.tsx 73.68% <78.94%> (+12.81%) ⬆️
.../legend-studio/src/components/shared/AppHeader.tsx 100.00% <100.00%> (ø)

@akphi akphi merged commit c1e3047 into finos:master Apr 2, 2021
@akphi akphi deleted the sdlc-multi2 branch April 2, 2021 18:11
@github-actions github-actions bot mentioned this pull request Apr 2, 2021
@akphi
Copy link
Contributor Author

akphi commented May 3, 2021

This addresses several points in #100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants