Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify Query to have classPath as tagged value when we save it via different query workflows #2018

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

gayathrir11
Copy link
Contributor

@gayathrir11 gayathrir11 commented Mar 16, 2023

Summary

#2006

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@gayathrir11 gayathrir11 requested a review from a team as a code owner March 16, 2023 13:00
@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2023

🦋 Changeset detected

Latest commit: c7b305e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@finos/legend-extension-dsl-data-space Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-taxonomy-bootstrap Patch
@finos/legend-application-taxonomy Patch
@finos/legend-manual-tests Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-taxonomy-deployment Patch
@finos/legend-application-pure-ide-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

xannem
xannem previously approved these changes Mar 16, 2023
@gayathrir11 gayathrir11 marked this pull request as draft March 17, 2023 07:24
@akphi akphi marked this pull request as ready for review March 17, 2023 07:24
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #2018 (c7b305e) into master (cc0030d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #2018      +/-   ##
==========================================
- Coverage   40.30%   40.29%   -0.01%     
==========================================
  Files        1447     1447              
  Lines       66016    66024       +8     
  Branches    15494    15494              
==========================================
  Hits        26607    26607              
- Misses      39308    39316       +8     
  Partials      101      101              
Impacted Files Coverage Δ
...xtension-dsl-data-space/src/DSL_DataSpace_Const.ts 0.00% <0.00%> (ø)
...ace/src/stores/query/DataSpaceQueryCreatorStore.ts 4.47% <0.00%> (-0.53%) ⬇️

@akphi akphi merged commit 4f622a8 into finos:master Mar 17, 2023
@gayathrir11 gayathrir11 deleted the persist branch May 19, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants