Simple relational mapping editor and minor editor improvements #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2bce53a The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
18 tasks
...c/components/editor/edit-panel/mapping-editor/relational/RelationalPropertyMappingEditor.tsx
Outdated
Show resolved
Hide resolved
...c/components/editor/edit-panel/mapping-editor/relational/RelationalPropertyMappingEditor.tsx
Outdated
Show resolved
Hide resolved
...or-state/element-editor-state/mapping/relational/RelationalInstanceSetImplementationState.ts
Show resolved
Hide resolved
| @@ -0,0 +1,8 @@ | |||
| import { isEmpty } from '@finos/legend-studio-shared'; | |||
|
|
|||
| export type RawRelationalOperationElement = object; // @MARKER GENERATED MODEL DISCREPANCY --- Studio does not process relational operation element | |||
There was a problem hiding this comment.
Are we ever going to need an operation element resolver? do we resolve for any table,view, db in the processing logic?
There was a problem hiding this comment.
looking at V1_processRelationalOperationElement there is a resolver for a relational. we might need to address with another 'resolver'. might be easier since the code is already rewritten for this
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
- Coverage 48.63% 48.26% -0.37%
==========================================
Files 695 701 +6
Lines 32826 33235 +409
Branches 7436 7547 +111
==========================================
+ Hits 15965 16042 +77
- Misses 16805 17137 +332
Partials 56 56
|
MauricioUyaguari
approved these changes
May 18, 2021
Merged
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groundwork for #202
Fixes #206