refactor snowflake app function activator flow #2791
Conversation
🦋 Changeset detectedLatest commit: 6b1edf0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
YannanGao-gs
force-pushed
the
extension
branch
2 times, most recently
from
5492eca
to
fe24964
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2791 +/- ##
==========================================
- Coverage 49.29% 48.97% -0.32%
==========================================
Files 1971 1979 +8
Lines 324367 324739 +372
Branches 12626 12556 -70
==========================================
- Hits 159888 159034 -854
- Misses 164199 165413 +1214
- Partials 280 292 +12
|
YannanGao-gs
force-pushed
the
extension
branch
from
5362b46
to
302c5fa
Compare
YannanGao-gs
force-pushed
the
extension
branch
2 times, most recently
from
91c9a07
to
766237f
Compare
YannanGao-gs
force-pushed
the
extension
branch
from
d21c45b
to
6b1edf0
Compare
| @@ -161,6 +161,12 @@ export type NewElementFromStateCreator = ( | |||
| type: string, | |||
| name: string, | |||
| state: NewElementState, | |||
| options?: { | |||
| /** | |||
| * decorElement might be used when creating a new element -> ???? rename rename | |||
There was a problem hiding this comment.
Can you please remove the rename comment here
| @@ -693,7 +693,9 @@ const FunctionPromoteEditor = observer( | |||
| let validationMessage = ''; | |||
| const closeModal = (): void => { | |||
| activatorPromoteState.closeFunctionPromoteModal(); | |||
| activatorPromoteState.setPromoteType(undefined); | |||
| activatorPromoteState.setPromoteType( | |||
| FUNCTION_PROMOTE_TYPE.SNOWFLAKE_NATIVE_APP, | |||
There was a problem hiding this comment.
I don't think we should have reference to snowflake app in core if we are thinking to plug it as an extension
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
|
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated. |
Summary
How did you test this change?
Screen.Recording.2023-11-16.at.2.51.41.PM.mov