Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable new query button in query create flow #3179

Merged
merged 1 commit into from
May 28, 2024

Conversation

YannanGao-gs
Copy link
Contributor

@YannanGao-gs YannanGao-gs commented May 22, 2024

Summary

enable new query button in query create flow

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@YannanGao-gs YannanGao-gs requested a review from a team as a code owner May 22, 2024 15:23
Copy link

changeset-bot bot commented May 22, 2024

🦋 Changeset detected

Latest commit: 38a4541

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@finos/legend-application-query Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 41.30435% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 47.97%. Comparing base (1ce2ea7) to head (38a4541).
Report is 98 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3179      +/-   ##
==========================================
- Coverage   48.20%   47.97%   -0.24%     
==========================================
  Files        2007     1976      -31     
  Lines      338437   335748    -2689     
  Branches    13019    12769     -250     
==========================================
- Hits       163139   161066    -2073     
+ Misses     174989   174386     -603     
+ Partials      309      296      -13     
Files Coverage Δ
...d-application-query/src/stores/QueryEditorStore.ts 39.29% <100.00%> (-2.90%) ⬇️
...c/components/Core_LegendQueryApplicationPlugin.tsx 47.23% <37.20%> (+47.23%) ⬆️

... and 165 files with indirect coverage changes

@YannanGao-gs YannanGao-gs self-assigned this May 22, 2024
@MauricioUyaguari MauricioUyaguari merged commit 43b16a3 into finos:master May 28, 2024
13 checks passed
MauricioUyaguari pushed a commit to MauricioUyaguari/legend-studio that referenced this pull request May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants