generated from finos/software-project-blueprint
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Legend Query MVP #390
Merged
Merged
Legend Query MVP #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 13292d4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #390 +/- ##
==========================================
- Coverage 46.17% 45.46% -0.71%
==========================================
Files 753 756 +3
Lines 35400 36056 +656
Branches 8221 8384 +163
==========================================
+ Hits 16345 16394 +49
- Misses 18994 19601 +607
Partials 61 61
|
MauricioUyaguari
approved these changes
Aug 9, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #325
Improvements
QueryStore
groupId
andartifactId
for query when using SDLCSave
andSaveAs/Create
independently - this requires credential checksshowCurrentUserQueriesOnly === true
showCurrentUserQueriesOnly
when searching for existing queriesQuery
protocol to only has 1 ownerHEAD
forlatest revision
asversionId
of querylatest
asversionId
of querymetadata
server instead ofSDLC
serverOthers
INTERNAL__
for unknown model classes (related to RFC: Support for the unsupported #315)eslint-plugin-import
import/no-extraneous-dependencies
rule to check for undeclared dependencies (Dependencies Watchman #83)ActionState
to hideACTION_STATE
and make sureSetupStore
usesActionState
mobx
@flow
when we don't need to modify observable states (e.g.AbstractGraphManager
,V1_Engine
, etc.)