Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legend Query MVP #390

Merged
merged 31 commits into from
Aug 9, 2021
Merged

Legend Query MVP #390

merged 31 commits into from
Aug 9, 2021

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Aug 4, 2021

Fixes #325

Improvements

  • Use a separate method to build the graph for QueryStore
  • Provide user with more context in editor by showing a tab bar about query info on the header
  • Show a home button on the header
  • Populate groupId and artifactId for query when using SDLC
  • Show owner tag in get load queries menu
  • Support Save and SaveAs/Create independently - this requires credential checks
  • Allow deleting query from the home page when showCurrentUserQueriesOnly === true
  • Allow toggle showCurrentUserQueriesOnly when searching for existing queries
  • Adjust Query protocol to only has 1 owner
  • Support typeahead to search for query
  • Navigate to new query after it's created/saved in the editor
  • Make sure we reset query store properly when navigate in the app
  • Support alias HEAD for latest revision as versionId of query
  • Support alias latest as versionId of query
  • Use metadata server instead of SDLC server

Others

  • add prefix INTERNAL__ for unknown model classes (related to RFC: Support for the unsupported #315)
  • Enable eslint-plugin-import import/no-extraneous-dependencies rule to check for undeclared dependencies (Dependencies Watchman #83)
  • Rework ActionState to hide ACTION_STATE and make sure SetupStore uses ActionState
  • Reduce usage of mobx @flow when we don't need to modify observable states (e.g. AbstractGraphManager, V1_Engine, etc.)

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2021

🦋 Changeset detected

Latest commit: 13292d4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@finos/legend-studio-preset-query-builder Patch
@finos/legend-studio Patch
@finos/babel-preset-legend-studio Patch
@finos/eslint-plugin-legend-studio Patch
@finos/legend-query-app Patch
@finos/legend-studio-app Patch
@finos/legend-studio-components Patch
@finos/legend-studio-dev-utils Patch
@finos/legend-studio-manual-tests Patch
@finos/legend-studio-network Patch
@finos/legend-studio-plugin-management Patch
@finos/legend-studio-plugin-tracer-zipkin Patch
@finos/legend-studio-preset-dsl-text Patch
@finos/legend-studio-preset-external-format-json-schema Patch
@finos/legend-studio-shared Patch
@finos/stylelint-config-legend-studio Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Aug 4, 2021

Codecov Report

Merging #390 (13292d4) into master (ffa1c27) will decrease coverage by 0.70%.
The diff coverage is 11.00%.

@@            Coverage Diff             @@
##           master     #390      +/-   ##
==========================================
- Coverage   46.17%   45.46%   -0.71%     
==========================================
  Files         753      756       +3     
  Lines       35400    36056     +656     
  Branches     8221     8384     +163     
==========================================
+ Hits        16345    16394      +49     
- Misses      18994    19601     +607     
  Partials       61       61              
Impacted Files Coverage Δ
...nt-plugin/src/configs/computationally-expensive.js 0.00% <ø> (ø)
packages/legend-query-app/src/index.tsx 0.00% <ø> (ø)
...nd-studio-components/src/components/LegendLogo.tsx 0.00% <ø> (ø)
...dio-plugin-tracer-zipkin/src/ZipkinTracerPlugin.ts 12.50% <ø> (ø)
...eset-query-builder/src/components/QueryBuilder.tsx 67.64% <0.00%> (+0.07%) ⬆️
...uilder/src/components/QueryBuilderLambdaEditor.tsx 7.69% <0.00%> (+2.93%) ⬆️
...der/src/components/QueryBuilderProjectionPanel.tsx 57.14% <ø> (ø)
...builder/src/components/QueryBuilderResultPanel.tsx 40.81% <ø> (-0.70%) ⬇️
...ilder/src/components/QueryBuilder_EditorPlugin.tsx 33.33% <ø> (+5.67%) ⬆️
...c/components/standalone/LegendQueryApplication.tsx 6.25% <ø> (ø)
... and 88 more

@akphi akphi merged commit bbba2e3 into finos:master Aug 9, 2021
@akphi akphi deleted the xbb branch August 9, 2021 14:58
@github-actions github-actions bot mentioned this pull request Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Query builder standalone (MVP)
2 participants