Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #410

Merged
merged 29 commits into from
Aug 16, 2021
Merged

Refactor #410

merged 29 commits into from
Aug 16, 2021

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Aug 12, 2021

  • Improve ESLint rules mechanism to detect protocol version: before if a path contains something like /V123125dasldj it could be interpreted as the version number (this sometimes happen in the Gitlab pipeline)
  • Document and cleanup for auto re-authenticate mechanism using iframe
  • Rename init to initialize
  • Avoid exposing engine at graph manager level
  • Move logic out of Mapping into MappingHelper
  • Modularize Logger, now the application has a Log which has multiple Logger's in it. Also, we now require log event for all logger methods. This will help us extend Logger in the future to support features like channel, timestamp, etc.
  • Use react-reflex instead of react-split-pane through out the project
  • Set stage for more modularization (RFC: Modularization (last mile) #65)

@changeset-bot
Copy link

changeset-bot bot commented Aug 12, 2021

🦋 Changeset detected

Latest commit: 806181c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@finos/legend-studio-shared Patch
@finos/eslint-plugin-legend-studio Patch
@finos/legend-query-app Patch
@finos/legend-studio Patch
@finos/legend-studio-app Patch
@finos/legend-studio-components Patch
@finos/legend-studio-manual-tests Patch
@finos/legend-studio-network Patch
@finos/legend-studio-plugin-management Patch
@finos/legend-studio-plugin-tracer-zipkin Patch
@finos/legend-studio-preset-dsl-text Patch
@finos/legend-studio-preset-query-builder Patch
@finos/legend-studio-preset-external-format-json-schema Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@finos-cla-bot finos-cla-bot bot added the cla-present CLA Signed label Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #410 (806181c) into master (72d1da7) will decrease coverage by 0.09%.
The diff coverage is 33.11%.

@@            Coverage Diff             @@
##           master     #410      +/-   ##
==========================================
- Coverage   45.49%   45.40%   -0.10%     
==========================================
  Files         756      762       +6     
  Lines       36124    36165      +41     
  Branches     8414     8395      -19     
==========================================
- Hits        16435    16420      -15     
- Misses      19628    19684      +56     
  Partials       61       61              
Impacted Files Coverage Δ
packages/eslint-plugin/src/configs/recommended.js 0.00% <ø> (ø)
packages/eslint-plugin/src/index.js 0.00% <ø> (ø)
...plugin/src/rules/enforce-protocol-export-prefix.js 0.00% <0.00%> (ø)
...t-plugin/src/rules/enforce-protocol-file-prefix.js 0.00% <0.00%> (ø)
...ugin/src/rules/no-cross-protocol-version-import.js 0.00% <0.00%> (ø)
...n/src/rules/no-cross-workspace-unexposed-import.js 0.00% <0.00%> (ø)
packages/legend-query-app/src/index.tsx 0.00% <ø> (ø)
packages/legend-studio-app/src/index.tsx 0.00% <ø> (ø)
...components/src/testMocks/MonacoEditorMockUtils.tsx 0.00% <ø> (ø)
...ents/src/theme/LegendApplicationMaterialUITheme.ts 0.00% <0.00%> (ø)
... and 157 more

@akphi akphi marked this pull request as ready for review August 16, 2021 02:02
@MauricioUyaguari MauricioUyaguari merged commit a1dfc16 into finos:master Aug 16, 2021
@github-actions github-actions bot mentioned this pull request Aug 16, 2021
@akphi akphi deleted the seel branch August 16, 2021 13:28
@akphi akphi mentioned this pull request Aug 17, 2021
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants