generated from finos/software-project-blueprint
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor #410
Merged
Merged
Refactor #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 806181c The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report
@@ Coverage Diff @@
## master #410 +/- ##
==========================================
- Coverage 45.49% 45.40% -0.10%
==========================================
Files 756 762 +6
Lines 36124 36165 +41
Branches 8414 8395 -19
==========================================
- Hits 16435 16420 -15
- Misses 19628 19684 +56
Partials 61 61
|
MauricioUyaguari
approved these changes
Aug 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/V123125dasldj
it could be interpreted as the version number (this sometimes happen in the Gitlab pipeline)init
toinitialize
engine
atgraph manager
levelMapping
intoMappingHelper
Logger
, now the application has aLog
which has multipleLogger
's in it. Also, we now require log event for all logger methods. This will help us extendLogger
in the future to support features likechannel
,timestamp
, etc.react-reflex
instead ofreact-split-pane
through out the project