Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor cleanups #759

Merged
merged 3 commits into from
Dec 30, 2021
Merged

minor cleanups #759

merged 3 commits into from
Dec 30, 2021

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Dec 30, 2021

Summary

Minor cleanups post #737 and #748

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2021

🦋 Changeset detected

Latest commit: 270cccb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@finos/legend-application Patch
@finos/legend-art Patch
@finos/legend-dev-utils Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-serializer Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-external-store-service Patch
@finos/legend-graph Patch
@finos/legend-query Patch
@finos/legend-query-deployment Patch
@finos/legend-server-depot Patch
@finos/legend-server-sdlc Patch
@finos/legend-studio Patch
@finos/legend-studio-deployment Patch
@finos/legend-studio-extension-management-toolkit Patch
@finos/legend-studio-extension-query-builder Patch
@finos/legend-taxonomy Patch
@finos/legend-taxonomy-deployment Patch
@finos/legend-extension-external-language-morphir Patch
@finos/legend-query-app Patch
@finos/legend-studio-app Patch
@finos/legend-taxonomy-app Patch
@finos/legend-manual-tests Patch
@finos/legend-extension-external-format-json-schema Patch
@finos/legend-graph-extension-collection Patch
@finos/legend-model-storage Patch
@finos/legend-tracer-extension-zipkin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #759 (270cccb) into master (f493059) will decrease coverage by 0.04%.
The diff coverage is 29.54%.

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
- Coverage   42.99%   42.94%   -0.05%     
==========================================
  Files         933      934       +1     
  Lines       41358    41357       -1     
  Branches     9498     9498              
==========================================
- Hits        17782    17762      -20     
- Misses      23506    23525      +19     
  Partials       70       70              
Impacted Files Coverage Δ
...server-sdlc/src/models/workspace/WorkspaceUtils.ts 0.00% <ø> (ø)
...r/edit-panel/connection-editor/DatabaseBuilder.tsx 20.93% <0.00%> (ø)
...tion-editor/RelationalDatabaseConnectionEditor.tsx 27.86% <0.00%> (-0.11%) ⬇️
...nt-editor-state/connection/DatabaseBuilderState.ts 10.00% <0.00%> (ø)
...udio/src/stores/sidebar-state/LocalChangesState.ts 18.24% <0.00%> (-12.15%) ⬇️
...server-sdlc/src/models/entity/EntityChangeUtils.ts 25.80% <25.80%> (ø)
...kages/legend-query/src/stores/QueryBuilderState.ts 49.05% <60.00%> (ø)
...kages/legend-studio/src/stores/EditorGraphState.ts 40.51% <100.00%> (ø)

@MauricioUyaguari MauricioUyaguari merged commit 192e03d into finos:master Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-present CLA Signed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants