In Decimal class float method was contributed #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bensanchin
reviewed
May 8, 2024
Comment on lines
15
to
21
| {-| Test: Decimal/fromFloat | ||
| expected = 1.2 | ||
| -} | ||
| decimalFromFloatTest1 : TestContext -> Decimal | ||
| decimalFromFloatTest1 ctx = | ||
| test ctx | ||
| (Decimal.fromFloat 1.2) |
There was a problem hiding this comment.
Not sure if we need decimalFromFloatTest1.
decimalFromFloatTest looks to do the exact same thing with the exact same function -- fromFloat. import Morphir.SDK.Decimal as Decimal exposing (..) exposes fromFloat (and other Decimal functions) so that we could call it directly.
There was a problem hiding this comment.
Ok, removed the unnecessary changes.
| @@ -403,6 +403,7 @@ object EvaluatorMDMTests extends MorphirBaseSpec { | |||
| suite("Decimal Tests")( | |||
| suite("conversion")( | |||
| testEvaluation("fromFloat")("decimalTests", "decimalFromFloatTest")(Data.Decimal(1.2)), | |||
| testEvaluation("fromFloat")("decimalTests", "decimalFromFloatTest1")(Data.Decimal(1.2)), | |||
There was a problem hiding this comment.
No addition is necessary here?
bensanchin
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.