Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: zngly & morphir website integration #78

Merged
merged 3 commits into from
Feb 11, 2022
Merged

feat: zngly & morphir website integration #78

merged 3 commits into from
Feb 11, 2022

Conversation

zngly-vlad
Copy link
Contributor

Zngly/Morphir New Website Integration into Finos/Morphir

Zngly Work

Staging Work

Underlying changes

  • src folder now contains new structure

image

  • Docusaurs config for deployment set to finos/morphir. It should work on merge
  • cd morphir/website && npm run deploy once merged

image

  • Old readme replaced for new readme.
  • new static assets are added on top of the old assets

@mcleo-d @stephengoldbaum

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Feb 11, 2022

CLA Signed

The committers are authorized under a signed CLA.

@mcleo-d
Copy link
Member

mcleo-d commented Feb 11, 2022

Hi @ditto-vlad

Thanks so much for raising the pull request and the time and effort spent on this awesome build 🚀 💯 💯 💯

Can you confirm the PR removes the previous morphir microsite dependencies and completely replaces them with the new docusaurus v2 build?

Without running a diff, it'll be great to make sure the new build is completely clean.

Thanks one again!

James.

@zngly-vlad
Copy link
Contributor Author

@mcleo-d I can confirm the entire website directory has been replaced. More so it's the package.json which specifies dependencies. This has all been replaced with the new build.

If you are pulling from main upon the merge I would urge you do an npm install again to get the node modules up to date.

Afterwards you are free to run npm deploy. Double check the GitHub pages settings that it serves from the correct branch - gh-pages. This is the branch in which the command deploys to.

Copy link
Member

@stephengoldbaum stephengoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent. This is exciting.

@zngly-vlad
Copy link
Contributor Author

zngly-vlad commented Feb 11, 2022

One more note, the docs directory remains unchanged apart from 3 files that were empty and caused build errors. They were removed.

docs/team.md
docs/roadmap.md
docs/home.md

@mcleo-d
Copy link
Member

mcleo-d commented Feb 11, 2022

Hi @TheJuanAndOnly99 👋🏻

This pull request contributes a new docusaurus v2 microsite into the morphir repo. This means the previous website folder will be replaced with the content of this PR.

Can you configure the morphir repo to use netflify for future PR reviews and site builds. This means the current mechanism for publishing the morphir microsite will be updated to this new pattern of publication.

Also, please advise on the best timings for the PR to be merged as I recommend updating on a Monday rather than a Friday.

Feel free to contact me for more information 😀

James 🚀

@stephengoldbaum stephengoldbaum merged commit 877c8c7 into finos:main Feb 11, 2022
@zngly-vlad zngly-vlad deleted the feat/zngly/morphir branch February 14, 2022 10:12
@mcleo-d
Copy link
Member

mcleo-d commented Feb 15, 2022

@stephengoldbaum, @maoo and @TheJuanAndOnly99,

The next stage of the morphir microsite deployment and publication has been communicated to the FINOS team via the following private GitHub issue ... https://github.com/finos/metadata/issues/1133

Kind regards,

James.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants