-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: zngly & morphir website integration #78
Conversation
Hi @ditto-vlad Thanks so much for raising the pull request and the time and effort spent on this awesome build 🚀 💯 💯 💯 Can you confirm the PR removes the previous Without running a Thanks one again! James. |
@mcleo-d I can confirm the entire website directory has been replaced. More so it's the package.json which specifies dependencies. This has all been replaced with the new build. If you are pulling from main upon the merge I would urge you do an npm install again to get the node modules up to date. Afterwards you are free to run npm deploy. Double check the GitHub pages settings that it serves from the correct branch - gh-pages. This is the branch in which the command deploys to. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent. This is exciting.
One more note, the docs directory remains unchanged apart from 3 files that were empty and caused build errors. They were removed. docs/team.md |
Hi @TheJuanAndOnly99 👋🏻 This pull request contributes a new Can you configure the Also, please advise on the best timings for the PR to be merged as I recommend updating on a Monday rather than a Friday. Feel free to contact me for more information 😀 James 🚀 |
@stephengoldbaum, @maoo and @TheJuanAndOnly99, The next stage of the Kind regards, James. |
Zngly/Morphir New Website Integration into Finos/Morphir
Zngly Work
Staging Work
Underlying changes
cd morphir/website && npm run deploy
once merged@mcleo-d @stephengoldbaum