Additional View methods for faster accessing of row and column data. #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and into an exposed user API. All of this should be deleted.
texodus
changed the title
|
Thanks for the PR! This issue has bit-rotted (The bit-rot could be mostly alleviated by squashing and removing the un-necessary whitespace/auto-format changes) and I don't think we ever got to a consistent design for these APIs, specifically, how they replace/augment the existing `view.col_to_js_typed_array(). I think we've determined (through this work) that the current methods are insufficient for the high-performance chart data pipeline we envisioned, but we're not at a solution yet. Closing for now, we'll re-visit this in tandem with charting improvements. |
|
Also note that any changes like this should also have symmetric changes in python |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently much of the data exchange between the perspective data store and charting code happens via calls to
to_json. This blanket serialization approach might be better served with more precise data accessing. This is especially true when fetching columnar data, where passing a dict and index array can be much faster.