Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'virtual_mode' optional argument to setDataListener() #125

Merged
merged 1 commit into from
Mar 30, 2021

Conversation

texodus
Copy link
Member

@texodus texodus commented Mar 30, 2021

Adds an optional argument virtual_mode to the setDataListener() method.

table.setDataListener(listener, {virtual_mode: "vertical"})

There are four virtual modes supported, including the previous (now default) behavior "both". The three new values each disable one or both virtual scroll axes:

  • "both" (default) virtualizes scrolling on both axes.
  • "vertical" only virtualizes vertical (y) scrolling.
  • "horizontal" only virtualizes horizontal (x) scrolling.
  • "none" disable all scroll virtualization.

Note that using a virtual_mode other than the default "both" will render the entire <table> along the non-virtual axis(es), and may cause rendering performance degradation.

@texodus texodus merged commit 7a1c648 into master Mar 30, 2021
@texodus texodus deleted the disable-virtual branch March 30, 2021 07:59
@texodus texodus added breaking enhancement Feature requests or improvements labels Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking enhancement Feature requests or improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant