Linear column scrolling #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texodus
force-pushed
the
linear-column-scrolling
branch
from
35825bd
to
b81d28b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, horizontal scrolling was calculated by evenly distributing the available
scrollWidthamong the viewable columns. This worked fine and arguably made cell-aligned-scrolling more pleasant, but caused a perceived scroll position drift when theregular-tabledimensions were changed as thescrollWidth/offsetWidthratio changed. This PR makes this behave linear with the column sizes, so e.g. scrolling through a 200px column will take twice as many pixels as a 100px column. This scrolling model works better (arguably) with sub-cell scrolling introduced in0.5.0, and more importantly does not cause position drift.