Fix debounce interference between multiple regular-table
#158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…present on the same page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calls to
<regular-table>'s async.draw()method are debounced while the previous.draw()call is still being processed. Calls debounced in this manner are then squashed when the previous call completes, with only the last such call being invoked, the assumption being that all previous calls have been superseded. The async mutex which implements the debounce behavior was mistakenly set to the class object however, causing.draw()calls to multiple<regular-table>s on the same page to debounce each other; this PR moves the async mutex to the instance instead.