Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry / File State Storage #385

Merged
merged 24 commits into from
May 17, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
3f2fec6
SYMPHONYP-940 MS Teams feature to submit the adaptive card
vaibhav-db Feb 24, 2023
25a538f
Pull request #29: SYMPHONYP-940 MS Teams feature to submit the adapti…
vaibhav-db Feb 27, 2023
a9f3699
SYMPHONYP-940 refactor retry handler
vaibhav-db Mar 2, 2023
2d448ea
Merge branch 'spring-bot-master' of https://stash.gto.intranet.db.com…
vaibhav-db Mar 2, 2023
80509b3
SYMPHONYP-939 implements review comments
vaibhav-db Mar 15, 2023
b9a31ff
added testcases for Message Retry.
abhishekdahiya-db Mar 16, 2023
3e4b60c
review comments changes done.
abhishekdahiya-db Mar 21, 2023
1781441
Pull request #30: SYMPHONYP-940 refactor retry handler
vaibhav-db Mar 27, 2023
18d766f
bug fix implemented.
abhishekdahiya-db Mar 31, 2023
add1a4d
refactor retry message handler
vaibhav-db Mar 31, 2023
4b9e848
refactor retry message handler
vaibhav-db Mar 31, 2023
5c475ca
refactor retry message handler
vaibhav-db Mar 31, 2023
f49836b
Pull request #31: bug fix implemented.
abhishekdahiya-db Apr 3, 2023
a5496fe
refactor retry message handler
vaibhav-db Apr 4, 2023
e2c1e8e
refactor retry message handler
vaibhav-db Apr 4, 2023
320488b
refactor retry message handler
vaibhav-db Apr 5, 2023
be97480
Pull request #32: Feature/SYMPHONYP-947 teams spring bot retry handle…
vaibhav-db Apr 5, 2023
115d93e
Fixed state storage testcases
vaibhav-db Apr 7, 2023
eb8de4a
State storage testcases.
vaibhav-db Apr 14, 2023
8f82361
refactor file stage storage and testcase
vaibhav-db Apr 21, 2023
3bf0ea7
Teams retry InMemory handler
vaibhav-db Apr 27, 2023
784b2c7
Teams retry InMemory handler
vaibhav-db Apr 27, 2023
7e21035
Corrected InMemoryRetryingActivityHandler reference
vaibhav-db May 2, 2023
9007a16
Error stream id in log
vaibhav-db May 3, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
import org.finos.springbot.teams.conversations.TeamsConversationsConfig;
import org.finos.springbot.teams.form.TeamsFormConverter;
import org.finos.springbot.teams.form.TeamsFormDeserializerModule;
import org.finos.springbot.teams.handlers.InMemoryMessageRetryHandler;
import org.finos.springbot.teams.handlers.MessageRetryHandler;
import org.finos.springbot.teams.handlers.ActivityHandler;
import org.finos.springbot.teams.handlers.SimpleActivityHandler;
import org.finos.springbot.teams.handlers.TeamsResponseHandler;
import org.finos.springbot.teams.history.StateStorageBasedTeamsHistory;
import org.finos.springbot.teams.history.StorageIDResponseHandler;
Expand Down Expand Up @@ -75,8 +75,7 @@
ThymeleafEngineConfig.class,
AdaptiveCardConverterConfig.class,
ThymeleafConverterConfig.class,
TeamsConversationsConfig.class,
TeamsScheduledConfig.class
TeamsConversationsConfig.class
})
@Profile("teams")
public class TeamsWorkflowConfig {
Expand Down Expand Up @@ -129,16 +128,23 @@ public TeamsResponseHandler teamsResponseHandler(
AdaptiveCardTemplateProvider formTemplater,
ThymeleafTemplateProvider displayTemplater,
TeamsStateStorage th,
TeamsConversations tc,
MessageRetryHandler mr) {
ActivityHandler ah) {
return new TeamsResponseHandler(
null, // attachment handler
markupTemplater,
formTemplater,
displayTemplater,
th,
tc,
mr);
ah);
}

/**
If you want to include retry logic for activities, override this bean and return an instance of InMemoryRetryingActivityHandler
*/
@Bean
@ConditionalOnMissingBean
public ActivityHandler activityHandler(TeamsConversations tc) {
return new SimpleActivityHandler(tc);
}

@Bean
Expand Down Expand Up @@ -230,10 +236,5 @@ public void setResourceLoaderClassLoader() {
resourceLoader.setClassLoader(this.getClass().getClassLoader());
}

@Bean
@ConditionalOnMissingBean
public MessageRetryHandler messageRetryHandler() {
return new InMemoryMessageRetryHandler();
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
package org.finos.springbot.teams.handlers;

import java.util.concurrent.CompletableFuture;

import org.finos.springbot.teams.content.TeamsAddressable;

import com.microsoft.bot.schema.Activity;
import com.microsoft.bot.schema.ResourceResponse;

public interface ActivityHandler {

public CompletableFuture<ResourceResponse> handleActivity(Activity activity, TeamsAddressable to);
}

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
package org.finos.springbot.teams.handlers;

import java.util.concurrent.CompletableFuture;

import org.finos.springbot.teams.content.TeamsAddressable;
import org.finos.springbot.teams.conversations.TeamsConversations;

import com.microsoft.bot.schema.Activity;
import com.microsoft.bot.schema.ResourceResponse;

public class SimpleActivityHandler implements ActivityHandler {

private TeamsConversations tc;

public SimpleActivityHandler(TeamsConversations tc) {
this.tc = tc;
}

@Override
public CompletableFuture<ResourceResponse> handleActivity(Activity activity, TeamsAddressable to) {
return tc.handleActivity(activity, to);
}

}
Loading
Loading