Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#459 Automated release workflow #460

Merged
merged 2 commits into from Feb 24, 2021

Conversation

thibauult
Copy link
Member

Ticket

#459

Description

Automated release workflow using Github Actions.

@thibauult thibauult requested a review from a team as a code owner February 24, 2021 18:59
@thibauult thibauult merged commit 8bcad89 into finos:main Feb 24, 2021
@thibauult thibauult deleted the #459_Automate-Release-workflow branch February 24, 2021 19:02
@@ -0,0 +1,12 @@
# https://github.com/gradle/wrapper-validation-action#readme

name: "Validate Gradle Wrapper"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, were we going to accept an external PR with a JAR change?
But then did you check the source code of the action to make sure it was not doing anything suspicious it self 😛

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope so ! Otherwise we should really contact the Spring Boot team https://github.com/spring-projects/spring-boot/blob/master/.github/workflows/gradle-wrapper-validation.yml !


name: Release

on: [ workflow_dispatch ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about running it once a release is created in GH? So that we don't have to create the release + trigger the job? and triggering the release also means we are more likely to target a branch/tag that is actually a release

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or maybe we can keep both, upon release and manually

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep let me try this way!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants