New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#459 Automated release workflow #460
#459 Automated release workflow #460
Conversation
@@ -0,0 +1,12 @@ | |||
# https://github.com/gradle/wrapper-validation-action#readme | |||
|
|||
name: "Validate Gradle Wrapper" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question, were we going to accept an external PR with a JAR change?
But then did you check the source code of the action to make sure it was not doing anything suspicious it self 😛
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope so ! Otherwise we should really contact the Spring Boot team https://github.com/spring-projects/spring-boot/blob/master/.github/workflows/gradle-wrapper-validation.yml !
|
||
name: Release | ||
|
||
on: [ workflow_dispatch ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about running it once a release is created in GH? So that we don't have to create the release + trigger the job? and triggering the release also means we are more likely to target a branch/tag that is actually a release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or maybe we can keep both, upon release and manually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep let me try this way!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ticket
#459
Description
Automated release workflow using Github Actions.