Make Activity api offer asynchronous processing option #760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symphony-bdk-core/src/main/java/com/symphony/bdk/core/activity/AbstractActivity.java
Outdated
Show resolved
Hide resolved
...-boot-starter/src/main/java/com/symphony/bdk/spring/annotation/SlashAnnotationProcessor.java
Show resolved
Hide resolved
...les/bdk-core-examples/src/main/java/com/symphony/bdk/examples/activity/AsyncCommandMain.java
Outdated
Show resolved
Hide resolved
symphony-bdk-core/src/main/java/com/symphony/bdk/core/activity/command/HelpCommand.java
Show resolved
Hide resolved
...bdk-core-examples/src/main/java/com/symphony/bdk/examples/activity/GifFormReplyActivity.java
Show resolved
Hide resolved
...bdk-core-examples/src/main/java/com/symphony/bdk/examples/activity/GifFormReplyActivity.java
Show resolved
Hide resolved
.../bdk-spring-boot-example/src/main/java/com/symphony/bdk/examples/spring/GifFormActivity.java
Show resolved
Hide resolved
yinan-symphony
approved these changes
Apr 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Activity api, not being asynchronous, leads to a blocking issue where a command takes long time to get processed and blocks all incoming commands. In this PR, we make the activity api support asynchronous processing. This is reached by passing a new option
asynchronousto the slash annotation. In this case, an executor service is used to provide a separate thread to process the command and leaves the main thread free to receive new commands.The executor service uses "newCachedThreadPool" to avoid creating a new thread pool for each command as it will reuse the previously finished ones. The number of threads is unbounded by using this constructor. A factory ThreadFactoyBuilder is introduced to isolate the threads creation from the core code of AbstractActivity.