Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editing side on basketTrading partially fails #966

Closed
heswell opened this issue Nov 14, 2023 · 1 comment
Closed

Editing side on basketTrading partially fails #966

heswell opened this issue Nov 14, 2023 · 1 comment
Assignees
@naleeha
Labels
bug Something isn't working

Comments

@heswell
Copy link
Contributor

heswell commented Nov 14, 2023

Within the basket trading feature, whilst a basket is off market, side can be edited at Basket level and will update side on constituents.

Issue: when side is toggled at Basket Level constituents are updated but BasketTrading row is not updated.
@chrisjstevo chrisjstevo self-assigned this Nov 16, 2023
@chrisjstevo chrisjstevo added the bug Something isn't working label Nov 16, 2023
@naleeha
Copy link
Contributor

naleeha commented Nov 23, 2023

  • UI side bug: hard coded to Buy
  • Server side: if you update basket trading side, it flip the sides of constituents without checking whether parent side has actually changed. So if parent side is BUY and you change it to BUY - parent end up BUY but constituents ends up SELL

@naleeha naleeha assigned naleeha and unassigned chrisjstevo Nov 23, 2023
SVC-GL-OS-SYNC pushed a commit to UBS-IB/vuu that referenced this issue Dec 5, 2023
@naleeha
finos#966 when updating basket trade cell value, only update if diffe…
943cfd1 
…rent from current value
chrisjstevo pushed a commit that referenced this issue Dec 5, 2023
@naleeha @chrisjstevo
#966 when updating basket trade cell value, only update if different …
f4505d9 
…from current value
SVC-GL-OS-SYNC pushed a commit to UBS-IB/vuu that referenced this issue Dec 7, 2023
@naleeha
finos#966 when updating basket trade cell value, only update if diffe…
436c889 
…rent from current value
@naleeha naleeha closed this as completed Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naleeha naleeha

Labels
bug Something isn't working
Projects
Vuu board
Archived in project
Milestone
No milestone
Development

When branches are created from issues, their pull requests are automatically linked.

issue_966-editing-side-on-baskettrading-partially-fails finos/vuu
3 participants
@heswell @chrisjstevo @naleeha