Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the issue: Create child orders in IgniteOrderLoaderMain created less than expected due to method is not threadsafe #1367

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Fix the issue: Create child orders in IgniteOrderLoaderMain created less than expected due to method is not threadsafe #1367

merged 1 commit into from
Jun 5, 2024

Conversation

wendymiaoo
Copy link
Contributor

@wendymiaoo
Fix the issue: Create child orders in IgniteOrderLoaderMain created l…
6b4187d 
…ess than expected due to method is not threadsafe
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 29, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@netlify Netlify
Copy link

netlify bot commented May 29, 2024 •
edited
Loading

✅ Deploy Preview for papaya-valkyrie-395400 canceled.

Name Link
🔨 Latest commit 6b4187d
🔍 Latest deploy log https://app.netlify.com/sites/papaya-valkyrie-395400/deploys/6656f316efad5e00083132ed

@wendymiaoo wendymiaoo marked this pull request as ready for review June 5, 2024 08:17
@wendymiaoo
Copy link
Contributor Author

@keikeicheung / @junaidzm13 , kindly please review it

@wendymiaoo wendymiaoo marked this pull request as draft June 5, 2024 08:37
@wendymiaoo wendymiaoo marked this pull request as ready for review June 5, 2024 08:37
@wendymiaoo
Copy link
Contributor Author

hi @naleeha , could you help review the code?

@naleeha
Copy link
Contributor

naleeha commented Jun 5, 2024

@wendymiaoo change looks good. Appreciate its demo code and doesn't have existing tests. How are you testing this? Is it easy to reproduce the issue / assert it is resolved now by running it?

@heswell heswell merged commit b1a0a7a into finos:main Jun 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@naleeha naleeha naleeha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wendymiaoo @naleeha @heswell