Application settings management phase 2 #1408
Conversation
✅ Deploy Preview for papaya-valkyrie-395400 canceled.
|
| console.log( | ||
| `Cannot change setting '${propertyName}'.\nDid you forget to declare an ApplicationProvider ?` | ||
| ), | ||
| settings: { | ||
| applicationSettings: { |
There was a problem hiding this comment.
we have an instance of a concrete settings structure here, along with a concrete implementation of an applicationSettingsSchema.
I think maybe its ok to keep the themeMode, as we are using it in the SaltProvider, but the rest don't belong in the library code, they would be provided by client code - i.e in the application that is using the ApplicationContext Provider.
Even with themeMode, we probably shouldn't assume that an app will support light and dark.
Sometimes it makes sense to provide default value(s) for the context object managed by a Provider. I don't think it does here.
| useCallback, | ||
| } from "react"; | ||
| import { HTMLAttributes } from "react"; | ||
| import { SettingsForm, SettingsSchema } from "./SettingsForm"; |
There was a problem hiding this comment.
SettingsSchema can be removed - per the lint error below, its not being used.
| return <Input value={value} />; | ||
| } | ||
| } | ||
| import { useApplicationSettings } from "../application-provider"; | ||
|
|
||
| // Props for Panel | ||
| export interface ApplicatonSettingsPanelProps |
There was a problem hiding this comment.
because ApplicationSettingsPanel no longer implements any props of its own (just inherits from HTMLDivEl;ement), no need to specify a type for the props, just use HTMLAttributes<HTMLDivElement> directly as the type.
If you DID want to declare a type, you would use type rather than interface, so
export type ApplicatonSettingsPanelProps = HTMLAttributes<HTMLDivElement>;
this is just declaring an alias that doesn't add any new props.
| // import { ApplicatonSettingsPanelProps } from "./ApplicationSettingsPanel"; | ||
|
|
||
| //Props for Form | ||
| export interface ApplicatonSettingsPanelProps |
| SyntheticEvent, | ||
| useCallback, | ||
| } from "react"; | ||
| // import { ApplicatonSettingsPanelProps } from "./ApplicationSettingsPanel"; |
No description provided.