Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SvelteComponent wrapper not calling destroy when disposed #7000

Closed
davidwatkins73 opened this issue Feb 23, 2024 · 0 comments
Closed

SvelteComponent wrapper not calling destroy when disposed #7000

davidwatkins73 opened this issue Feb 23, 2024 · 0 comments
Assignees
@davidwatkins73
Labels
bug Defect affecting the currently released version of Waltz fixed (test & close) An issue has been fixed, merged into master and is ready for further testing
Milestone
1.58.1

Comments

@davidwatkins73
Copy link
Member

Description

We wrap svelte widges in a waltz-svelte-component hosted on an angular page. This works well, however we have noticed that when the parent angular widget is removed the destroy methods are not being invoked. This could lead to a gradual memory leakage and increased workload (as events need to be processed by 'dead' components).

Waltz Version

1.58 (and earlier)

Steps to Reproduce

No response

Expected Result

No response

Actual Result

No response
@davidwatkins73 davidwatkins73 added the bug Defect affecting the currently released version of Waltz label Feb 23, 2024
@davidwatkins73 davidwatkins73 added this to the wip : 1.58.1 milestone Feb 23, 2024
@davidwatkins73 davidwatkins73 self-assigned this Feb 23, 2024
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Feb 23, 2024
@davidwatkins73
Waltz Svelte Component now cascades destroy events from angular to sv…
914e056 
…elte

finos#7000
@davidwatkins73 davidwatkins73 mentioned this issue Feb 23, 2024
Merged
@davidwatkins73 davidwatkins73 added the fixed (test & close) An issue has been fixed, merged into master and is ready for further testing label Feb 23, 2024
@JWoodland-Scott JWoodland-Scott modified the milestones: done : 1.58.1, 1.58.1 Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwatkins73 davidwatkins73

Labels
bug Defect affecting the currently released version of Waltz fixed (test & close) An issue has been fixed, merged into master and is ready for further testing
Projects
None yet
Milestone
1.58.1
Development

No branches or pull requests
2 participants
@davidwatkins73 @JWoodland-Scott