Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DASH-130 Add Admin Partner profile creation page #833

Merged
merged 1 commit into from
Nov 10, 2022
Merged

Conversation

vmkarpenko
Copy link
Contributor

No description provided.

Copy link
Contributor

@trukhilio trukhilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check comments

@@ -0,0 +1,30 @@
import { AnyObject, RefProfile } from '../../../../types';

export const validate = (values: RefProfile): AnyObject => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use '@lemoncode/fonk' validation here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can’t find a way how to validate list of domains, so I used custom validation function

client/src/redux/admin/actions.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@trukhilio trukhilio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check one more comment


const onSetDefaultDomain = useCallback(
(domain: string) => {
// Nested field doesn't recognize correctly
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants