FIP-10 contract changes for new fee voting #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edrotthoff
changed the title
…ian is computed, clear the pending flag, the next vote will set it again, but do not increment the processed fees count
ericbutz
approved these changes
Oct 1, 2020
ericbutz
approved these changes
Oct 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR delivers the following --
the fio fees has a binary extension boolean field added called votes_pending.
all areas of the system using fio fees are modified to manage votes pending.
when fee voting occurs votes_pending is set true.
when fee update happens votes_pending is set false.
the fee update logic is modified to look at votes pending and to process 10 pending fees per call.
the structure of the feevotes table has been retired, a new fee vote structure feevote2 is put into place which allows backwards compatibility.