Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIP-40 testing #344

Merged
merged 13 commits into from
May 4, 2023
Merged

FIP-40 testing #344

merged 13 commits into from
May 4, 2023

Conversation

edrotthoff
Copy link
Contributor

FIP-40 first tests calling fio.perms actions

FIP-40 first tests calling fio.perms actions
@edrotthoff edrotthoff marked this pull request as draft March 22, 2023 17:23
Ed Rotthoff and others added 11 commits March 29, 2023 14:31
FIP-40 develop parameter validation and tests
FIP-40 smoke tests for permissions and action arguments
FIP-40 test cleanup
FIP-40 add tests for register address
FIP-40 tests for register address, transfer domain, and burn expired.
FIP-40 make test work for non fio.address call to clearperm.
FIP-40 add happy path tests for getters
FIP-40 endpoint tests
FIP-40 update tests and fix tpid is domain only bug
FIP-40 prepare for develop merge
FIP-40 merge develop into dev branch
@adsorptionenthalpy
Copy link
Member

adsorptionenthalpy commented May 3, 2023

Can't get the tests to pass
image

hi Adam.
when I run these tests on my local dev box, I get the following results...

************************** nft-uniqueness.js **************************
A. Add same NFT to multiple users
✓ Create 50 new users (21788ms)
✓ has 50 new users
minting the same NFT for all 50 test users
mass assignment complete
✓ add the same NFT to 50 users (7199ms)
✓ verify get_nfts_hash returns all 50 users NFTs
✓ verify get_nfts_contract returns all 50 users NFTs
validating NFTs by FIO address for all 50 users
done
✓ verify get_nfts_fio_address returns all 50 users NFTs (53ms)
✓ (populated values) add a similar NFT to user1 FIO address (163ms)
✓ (unhappy - blank contract_address, chain_code, token_id) add a similar NFT to user1 FIO address (161ms)
removing all 50 users NFTs
done
✓ remove all 50 users NFTs (6818ms)

I recommend first, for tests that fail, when performing QA level testing, it is helpful to understand if the failure occurs when the test in question is run as .only in the test suite....when we QA fio, we always do runs as a whole, then if there are failures we run the failed tests as .only on the same server, if the error persists in the .only configuration then the error is logged as a bug and assigned...

presently there are no tests that fail when performing the tests in this manner....for the tests you mention, the tests passed without having to run them .only in a local dev env...

let me know if you want to do more follow up on this, it might be more useful if we go offline from FIP-40 and ensure you are comfortable with how the QA level testing is performed....

thanks

FIP-40 timing issue and error message
@edrotthoff edrotthoff marked this pull request as ready for review May 4, 2023 19:27
@edrotthoff edrotthoff merged commit 25ccdc3 into develop May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants