Skip to content

Commit

Permalink
Merge pull request #149 from virajkanwade/master
Browse files Browse the repository at this point in the history
Added note about numeric channel names in redis
  • Loading branch information
fiorix committed Sep 30, 2014
2 parents b81a3cc + b30e178 commit a7e84ab
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
2 changes: 1 addition & 1 deletion cyclone/sse.py
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def _execute(self, transforms, *args, **kwargs):
self.flush()
self.request.connection.setRawMode()
self.notifyFinish().addCallback(self.on_connection_closed)
self.bind()
self.bind(*args, **kwargs)

def on_connection_closed(self, *args, **kwargs):
if self.settings.get("debug"):
Expand Down
8 changes: 8 additions & 0 deletions demos/redis/README
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,11 @@ Test redis pubsub feature (redis 2.x)
Send messages to channels:
curl -D - -d "message=hello world" http://localhost:8888/queue/foo.bar
curl -D - -d "message=yes, we can" http://localhost:8888/queue/l33t

NOTE
----

1. It is recommned not to use numeric channel names. The QueueHandler will
get the channel as integer while at other places it would be string.
If you still want to use numeric channel name, make sure you cast the
name to str to avoid any issues.

0 comments on commit a7e84ab

Please sign in to comment.