Unit tests for the core HTTPRequest class. #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's a bit of edge case behaviour with dealing with IPs that is currently untested, but this shouldnt be a big issue.
|
EDIT: ignore me I'm blind. |
fiorix
added a commit
that referenced
this pull request
Aug 11, 2014
Unit tests for the core HTTPRequest class.
|
That's fine. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bit of edge case behaviour with dealing with IPs that
is currently untested, but this shouldn't be a big issue.
Will try be a bit more descriptive with my PR's and commits
now :)
I'm just opening these PRs as I get tests done. Are you cool
with that @fiorix? Let me know if you'd like to do it another
way.