Using Grouped Datatype

[dwilkie]

Hi @fiorix, firstly may thanks for this library. I just started using it today and I'm having some trouble with the Grouped datatype.

I added the following AVP definitions to the dictionary according to http://tools.ietf.org/html/rfc4006#section-8.46

<diameter>
  <application id="0">
    <avp name="Subscription-Id" code="443" must="M" may="P" must-not="V" may-encrypt="-">
      <data type="Grouped"/>
    </avp>

    <avp name="Subscription-Id-Type" code="450" must="M" may="P" must-not="V" may-encrypt="Y">
      <data type="Enumerated">
        <item code="0" name="END_USER_E164"/>
        <item code="1" name="END_USER_IMSI"/>
        <item code="2" name="END_USER_SIP_URI"/>
        <item code="3" name="END_USER_NAI"/>
      </data>
    </avp>

    <avp name="Subscription-Id-Data" code="444" must="M" may="P" must-not="V" may-encrypt="Y">
      <data type="UTF8String"/>
    </avp>

  </application>
</diameter>

In my client I've done this:

const (
  SubscriptionIdType = datatypes.Enumerated(0x00)
  SubscriptionIdData = datatypes.UTF8String("85560234567")
)

func NewClient(c diam.Conn) {
  m := diam.NewRequest(272, 0, nil)
  m.NewAVP("Subscription-Id", 0x40, 0x0, datatypes.Grouped([SubscriptionIdType, SubscriptionIdData]))

Just having a problem with the last line. How to make a NewAVP which is of type Grouped and contains the other two types?

[fiorix]

Hi David. I've added a test case for that and it serves as an example. Let me know if you still have questions.

[dwilkie]

Thanks for that. Great example.

I'm adding some AVPs to diam/dict/default.go in https://github.com/dwilkie/go-diameter/ with respect to http://tools.ietf.org/html/rfc4006. I'm not sure if this is in the right place, but either way let me know and I can send a pull request if you're happy to have this included.

[fiorix]

The dictionary in default.go is actually the base dictionary from rfc6733. Maybe it should be renamed to basedict.go and the one for rfc4006 could be named ccdict.go.

The contents of the default.go is actually a copy of dict/testdata/base.xml. Would be great to have dict/testdata/cc.xml for credit control apps. Also, would be great to track this on its own issue - not on this closed one.