Capabilities-Exchange validation fix to verify AppIDs in common vs. "all AppIDs" #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all AppIDs" Includes relevant unit test based on an MNO observed captures
facebook-github-bot
pushed a commit
to magma/magma
that referenced
this pull request
Jan 21, 2020
…1113) Summary: Pull Request resolved: #1113 The fix includes: Capabilities-Exchange validation fix to verify AppIDs in common vs. all AppIDs" pull request: fiorix/go-diameter#126 Reviewed By: xjtian Differential Revision: D19505108 fbshipit-source-id: 18b60ff8995fb63648428df1a7885446ad6d1171
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently CER/CEA AppIDs validation fails if not all message AppIDs are supported by the provided dictionary, while according to https://tools.ietf.org/html/rfc6733#page-60 we only need to find a common AppID.
Includes relevant unit test based on an MNO observed captures.