fix panic in avp.DecodeFromBytes #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in some cases method crashes with panic. Extra length check added.
panic: runtime error: slice bounds out of range
goroutine 27 [running]:
github.com/fiorix/go-diameter/diam.(*AVP).DecodeFromBytes(0xc003185d40, 0xc002f862a8, 0x28, 0x158, 0x4, 0xc0000a4050, 0x3, 0x800000c002686480)
/go/src/github.com/fiorix/go-diameter/diam/avp.go:74 +0x5b1
github.com/fiorix/go-diameter/diam.DecodeAVP(0xc002f862a8, 0x28, 0x158, 0x4, 0xc0000a4050, 0xc002686480, 0x8, 0x10)
/go/src/github.com/fiorix/go-diameter/diam/avp.go:45 +0x74
github.com/fiorix/go-diameter/diam.DecodeGrouped(0xc002f861f0, 0xe0, 0x210, 0x4, 0xc0000a4050, 0xc000389400, 0x0, 0x0)
/go/src/github.com/fiorix/go-diameter/diam/group.go:29 +0xfc
github.com/fiorix/go-diameter/diam.(*AVP).DecodeFromBytes(0xc003185b00, 0xc002f861e4, 0xec, 0x21c, 0x4, 0xc0000
|
I'm surprised this check isn't elsewhere. Perhaps there's something else going on here. Where does 12 come from? Tests are failing, cannot proceed before tests pass. |
|
For what it's worth I have had this happen as well, interested to see what this would do |
|
panic occurs on line 71/74 avp.go I think data given to DecodeFromBytes method is not valid. |
* in some cases method crashes with panic. Extra length check added.
not really sure, should it be 12 (payload = data[12:])
* Avp Length is already an int, no need for cast.
panic: runtime error: slice bounds out of range
goroutine 27 [running]:
github.com/fiorix/go-diameter/diam.(*AVP).DecodeFromBytes(0xc003185d40, 0xc002f862a8, 0x28, 0x158, 0x4, 0xc0000a4050, 0x3, 0x800000c002686480)
/go/src/github.com/fiorix/go-diameter/diam/avp.go:74 +0x5b1
github.com/fiorix/go-diameter/diam.DecodeAVP(0xc002f862a8, 0x28, 0x158, 0x4, 0xc0000a4050, 0xc002686480, 0x8, 0x10)
/go/src/github.com/fiorix/go-diameter/diam/avp.go:45 +0x74
github.com/fiorix/go-diameter/diam.DecodeGrouped(0xc002f861f0, 0xe0, 0x210, 0x4, 0xc0000a4050, 0xc000389400, 0x0, 0x0)
/go/src/github.com/fiorix/go-diameter/diam/group.go:29 +0xfc
github.com/fiorix/go-diameter/diam.(*AVP).DecodeFromBytes(0xc003185b00, 0xc002f861e4, 0xec, 0x21c, 0x4, 0xc0000
Note that, in order to choose Go 1.10, you must use go: "1.10" (a string), not go: 1.10 (a float). Using a float results in the use of Go 1.1. - https://docs.travis-ci.com/user/languages/go/
0rac1e
force-pushed
the
master
branch
2 times, most recently
from
541b376
to
cdebf4a
Compare
* Avp Length is already an int, no need for cast.
* in some cases method crashes with panic. Extra length check added.
not really sure, should it be 12 (payload = data[12:])
panic: runtime error: slice bounds out of range
goroutine 27 [running]:
github.com/fiorix/go-diameter/diam.(*AVP).DecodeFromBytes(0xc003185d40, 0xc002f862a8, 0x28, 0x158, 0x4, 0xc0000a4050, 0x3, 0x800000c002686480)
/go/src/github.com/fiorix/go-diameter/diam/avp.go:74 +0x5b1
github.com/fiorix/go-diameter/diam.DecodeAVP(0xc002f862a8, 0x28, 0x158, 0x4, 0xc0000a4050, 0xc002686480, 0x8, 0x10)
/go/src/github.com/fiorix/go-diameter/diam/avp.go:45 +0x74
github.com/fiorix/go-diameter/diam.DecodeGrouped(0xc002f861f0, 0xe0, 0x210, 0x4, 0xc0000a4050, 0xc000389400, 0x0, 0x0)
/go/src/github.com/fiorix/go-diameter/diam/group.go:29 +0xfc
github.com/fiorix/go-diameter/diam.(*AVP).DecodeFromBytes(0xc003185b00, 0xc002f861e4, 0xec, 0x21c, 0x4, 0xc0000
0rac1e
force-pushed
the
master
branch
2 times, most recently
from
a2dd034
to
cb0c531
Compare
0rac1e
force-pushed
the
master
branch
2 times, most recently
from
74be173
to
33fa2fe
Compare
simple channel receive instead of select with a single check TestHandleCER_VS_AuthSCTP was lower case
|
Good catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in some cases method crashes with panic. Extra length check added.
panic: runtime error: slice bounds out of range
goroutine 27 [running]:
github.com/fiorix/go-diameter/diam.(*AVP).DecodeFromBytes(0xc003185d40, 0xc002f862a8, 0x28, 0x158, 0x4, 0xc0000a4050, 0x3, 0x800000c002686480)
/go/src/github.com/fiorix/go-diameter/diam/avp.go:74 +0x5b1
github.com/fiorix/go-diameter/diam.DecodeAVP(0xc002f862a8, 0x28, 0x158, 0x4, 0xc0000a4050, 0xc002686480, 0x8, 0x10)
/go/src/github.com/fiorix/go-diameter/diam/avp.go:45 +0x74
github.com/fiorix/go-diameter/diam.DecodeGrouped(0xc002f861f0, 0xe0, 0x210, 0x4, 0xc0000a4050, 0xc000389400, 0x0, 0x0)
/go/src/github.com/fiorix/go-diameter/diam/group.go:29 +0xfc
github.com/fiorix/go-diameter/diam.(*AVP).DecodeFromBytes(0xc003185b00, 0xc002f861e4, 0xec, 0x21c, 0x4, 0xc0000