Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

SubscriberProtocol.*subscribe() returns stale deferred #28

Merged
merged 1 commit into from

4 participants

Anton Lazarev Don't Add Me To Your Organization a.k.a The Travis Bot Alexandre Fiori Alexey Palazhchenko
Anton Lazarev

Deferred returned by these methods was waiting for data to appear in replyQueue which never happened. Fixed this by submitting message type name to replyQueue if the type is anything but 'message'.

Anton Lazarev tonylazarew Fixed: SubscriberProtocol.*subscribe() returned stale deferred.
Deferred returned by these methods was waiting for data to appear in replyQueue which never happened. Fixed this by submitting message type name to replyQueue if the type is anything but 'message'.
29b0679
Don't Add Me To Your Organization a.k.a The Travis Bot

This pull request passes (merged 29b0679 into 5f9e76e).

Alexandre Fiori fiorix merged commit 565d688 into from
Alexandre Fiori
Owner

Thanks!

Alexey Palazhchenko

Hey! Check out our variant: https://github.com/smira/txRedis

What's the basic difference between your branch and core txRedis?
I was trying out txRedis for a while but switched back to txredisapi mainly because it supports transactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Aug 22, 2012
  1. Anton Lazarev

    Fixed: SubscriberProtocol.*subscribe() returned stale deferred.

    tonylazarew authored
    Deferred returned by these methods was waiting for data to appear in replyQueue which never happened. Fixed this by submitting message type name to replyQueue if the type is anything but 'message'.
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 0 deletions.
  1. +1 −0  txredisapi.py
1  txredisapi.py
View
@@ -1331,6 +1331,7 @@ def replyReceived(self, reply):
if reply[-3] == u"message":
self.messageReceived(None, *reply[-2:])
else:
+ self.replyQueue.put(reply[-3])
self.messageReceived(*reply[-3:])
def subscribe(self, channels):
Something went wrong with that request. Please try again.