Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not log IPs to make Antonio happy #61

Closed
ggarber opened this issue Mar 7, 2016 · 5 comments
Closed

Do not log IPs to make Antonio happy #61

ggarber opened this issue Mar 7, 2016 · 5 comments

Comments

@ggarber
Copy link
Collaborator

ggarber commented Mar 7, 2016

No description provided.

@fippo
Copy link
Owner

fippo commented Mar 7, 2016

log but process. From fippo/rtcstats#19:

  • c= line in any SDP
  • a=rtcp line in any SDP
  • a=candidate line in any SDP
  • any onicecandidate / addIceCandidate event
  • getStats

@fippo
Copy link
Owner

fippo commented Apr 19, 2016

hrm. I just looked at webrtc-internals dumps and it looked like they only put the two higher bytes. Can you check @ggarber? Would solve the getStats problem at least.

@fippo
Copy link
Owner

fippo commented Apr 19, 2016

"Cand-JIjQ6xAA-ipAddress": {
     "startTime": "2016-04-15T08:54:03.919Z",
     "endTime": "2016-04-15T08:54:03.919Z",
     "values": "[52.58,52.58

not sure whether this is in getstats or the webrtc-internals dump...

@fippo
Copy link
Owner

fippo commented Apr 20, 2016

turns out to be a bug in webrtc-internals: https://bugs.chromium.org/p/chromium/issues/detail?id=605046

@fippo
Copy link
Owner

fippo commented May 4, 2016

note: I want ip addresses in relay candidates to identify the turn server used

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants