Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] ip address obfuscation #81

Merged
merged 3 commits into from
May 23, 2016
Merged

[WIP] ip address obfuscation #81

merged 3 commits into from
May 23, 2016

Conversation

fippo
Copy link
Owner

@fippo fippo commented May 22, 2016 •
edited

will fix #61

  • c= line in any SDP
  • a=rtcp line in any SDP
  • a=candidate line in any SDP
  • any onicecandidate / addIceCandidate event
  • getStats

@fippo
Copy link
Owner Author

fippo commented May 22, 2016

I think there is just three places in getStats: googLocalAddress, googRemoteAddress (contain both host and port) and ipAddress

@fippo
Copy link
Owner Author

fippo commented May 22, 2016

@ggarber how does this look?

@ggarber
Copy link
Collaborator

ggarber commented May 23, 2016

All the things that I could think about are already addressed. I also took a look at the latests stats in C52 and didn't see any other place with ip addresses

LGTM

@fippo fippo merged commit 7f333ad into develop May 23, 2016
@fippo fippo deleted the obfuscate branch May 23, 2016 19:27
@fippo
Copy link
Owner Author

fippo commented May 23, 2016

fab. One less blocker for deployment :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fippo @ggarber