-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save data in temporary file instead of memory #106
Conversation
7331f4e
to
aca9781
Compare
def669c
to
539bb13
Compare
deployed, seems to survive longer now... |
9824499
to
003493d
Compare
since snoop crashes with OOM ~150 times a day for me right I am writing things to disk for now.
after deleting stale data snoop-server just survived for at least nine hours without dying. This looks good.. |
generateFeatures(referer, client, clientid); | ||
delete db[referer][clientid]; | ||
tempStream.on('finish', function() { | ||
fs.readFile(tempStream.path, {encoding: 'utf-8'}, function(err, data) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At some point I think we will have to put this reading/processing part in a different process reading the collected files in background and extracting features.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah. I noticed that feature generation can take quite long which skews serverside timestamps.
I'm considering doing the accept in the cluster-master and the feature generation in a couple of workers. Also splitting up the big feature loop such that each feature is a setTimeout.
LGTM. Not sure if it is worth starting to use EC2 instances with SSD disk (not sure which ones have it now). Just an idea. |
yeah, I am currently running into disk-full issues with writing this to the root disk ;-) |
since snoop crashes with OOM ~150 times a day for me right now I am writing things to disk for now.