Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File explorer doesn't respond after displaying thumbnails #15

Closed
vivadavid opened this issue Sep 10, 2021 · 22 comments
Closed

File explorer doesn't respond after displaying thumbnails #15

vivadavid opened this issue Sep 10, 2021 · 22 comments
Labels
bug Something isn't working

Comments

@vivadavid
Copy link

Hi,

I've been waiting to be sure about it, but I've just noticed, once again, that a few seconds after the creation of thumbnails, file explorer doesn't respond, which means that I can't open another instance or even do something in the current instance.

I need to further investigate it, but it's happened to me while dealing with CBR and CBZ files, as I was trying to determine how long it takes for DarkThumbs to show a thumbnail from these types of tiles for the first time.
@vivadavid
Copy link
Author

Hello again! I've been doing more testing and I've noticed that also File Explorer doesn't respond after displaying thumbnails from MOBI and EPUB files.

@fire-eggs
Copy link
Owner

I've seen this problem occasionally as well. I've been trying to investigate potential causes with little luck so far.

A reboot usually clears it up. Not my preferred solution!

@fire-eggs fire-eggs added the bug Something isn't working label Oct 7, 2021
fire-eggs added a commit that referenced this issue Oct 11, 2021
@fire-eggs
Issue #15 : revert to origina T800 version of unrar, seems to be more…
6712f1f 
… stable
@fire-eggs
Copy link
Owner

I've made changes which so far seem to make Windows Explorer much more stable. At least in my testing, V1.3 could freeze Explorer within minutes, but so far V1.4 hasn't frozen Explorer at all!

I'd appreciate it if you could try V1.4 and see if it is better for you. Thanks!

@vivadavid
Copy link
Author

Hi, @fire-eggs ! I've done some testing and File Explorer stopped responding a couple of times. I think EPUB files are fine because the first time, File Explorer crashed after dealing with AZW/AZW3 files, and the second time, with CBR/CBZ files.

A couple of comments:

  1. The creation of thumbnails for CBR/CBZ files takes a little bit: around one second. The creation is definitely must faster with ebooks.

  2. No thumbnails are created for AZW/AZW3 files.

Please let me know if you want me to check something else. Thanks!

@fire-eggs fire-eggs reopened this Oct 11, 2021
@fire-eggs
Copy link
Owner

fire-eggs commented Oct 11, 2021 •
edited

Thanks for the feedback! I'll keep prodding at this then.

The creation of thumbnails for CBR/CBZ files takes a little bit: around one second.

Yes, I'm not happy with the performance either.

No thumbnails are created for AZW/AZW3 files.

I only have a few AZW* files to test with, and did get images for some. If you could provide a few samples, it would be helpful.

Thanks again!

@vivadavid
Copy link
Author

There you go, @fire-eggs :

https://drive.google.com/file/d/18xzBTtG5WBaOFmd8bDy-UVX6KlPLpYnz/view?usp=sharing

I've included a couple of AZW ebooks, but I'm not bothered about this format, as it's not used much and it's probably obsolete

By the way, there are plenty of ebooks in EPUB and AZW3 formats here: https://standardebooks.org/

@fire-eggs
Copy link
Owner

Hey, thanks! I'll check 'em out.

@fire-eggs
Copy link
Owner

No thumbnails are created for AZW/AZW3 files.

I tested the files you provided, and there are no problems:

image

@fire-eggs
Copy link
Owner

The creation of thumbnails for CBR/CBZ files takes a little bit: around one second. The creation is definitely must faster with ebooks.

The best suggestion I can make is to turn OFF the "Sort images alphabetically" option. With that option ON, the program does a full scan of CBR/CBZ files. If your CBR/CBZ files are anything like mine, the first image is the cover image, which will be shown if the option is OFF.

I have plans to optimize this but it will be a while.

@fire-eggs
Copy link
Owner

File Explorer crashed after dealing with AZW/AZW3

Shortly after testing the AZW/AZW3 files you provided, Explorer froze for me! Still trying to understand what's going on ...

@vivadavid
Copy link
Author

Hi @fire-eggs !

  1. I've deleted the thumbnail database and now I can see the covers for AZW* files. Sorry I didn't try this before!

  2. After doing that, I've noticed that no covers are displayed for EPUB3 files, but I think that this format isn't fully supported yet. You can't probably read an AZW3 file in an ebook reader, and as for Calibre, which supports any format, it's able to read the ebook, but it doesn't provide the cover either. Therefore, there must be something tricky about covers in EPUB3.

  3. Some time ago, you suggested keeping "Sort images alphabetically" on. I've tried turning it off, but it's not working for me (it was showing the wrong cover in some cases ) and I've turned it back on. My CBR & CBZ files are stored in a hard drive and not in an SSD, so chances are this makes an impact on speed.

  4. I was trying to be more specific about the circumstances where File Explorer freezes, hoping the problem only concerned old AZW files, but it just froze working with AZW3 files.

@fire-eggs
Copy link
Owner

My thanks again for all the testing and the sample files!

I'll have to dig into EPUB3 ...

@vivadavid
Copy link
Author

No problem! I'm glad to help!

Just in case, I've created a ZIP file containing EPUB3 ebooks from Standard Ebooks (https://standardebooks.org/):

https://drive.google.com/file/d/1Lvfj9IQLMzXvTqnch1FpbZNLskuXskma/view?usp=sharing

Again, there must be something peculiar about this format, as it's hard to find support for it, so don't bother too much. Thanks!

@fire-eggs
Copy link
Owner

Again, there must be something peculiar about this format, as it's hard to find support for it, so don't bother too much. Thanks!

Good point ... I really should focus on the stability issue before tackling more ebook formats ...

@vivadavid
Copy link
Author

I made a mistake with the ZIP file above, but it's fixed now and the file can be shared and downloaded.

@fire-eggs
Copy link
Owner

I uploaded a new installer. I pounded on it heavily with all the different file formats, singularly and all-together and no Explorer crash.

I'm hoping I've got it nailed down this time!

@fire-eggs fire-eggs mentioned this issue Oct 19, 2021
Closed
@vivadavid
Copy link
Author

I can't wait to test it as as soon as the installer is available.

@fire-eggs
Copy link
Owner

Sorry for being unclear - the "new" installer replaces the "V1.4" release.

@vivadavid
Copy link
Author

Thanks for the clarification, @fire-eggs ! Can I ask why you didn't publish the new installer as a new version?

@vivadavid
Copy link
Author

Although File Explorer has crashed once while producing covers for CBZ-CBR files (my laptop isn't the most reliable and needs a fresh install of Windows), DarkThumbs seems to be very stable now. This is the best experience I've had so far. Thanks!

@fire-eggs
Copy link
Owner

Thanks for the clarification, @fire-eggs ! Can I ask why you didn't publish the new installer as a new version?

A good question for which I don't have a good answer. There were no code changes to DarkThumbs "proper", merely rebuilding with a different version of unrar.h/lib. Felt more like a repackage of the same version.

@vivadavid
Copy link
Author

I see! I had no idea that without code changes, a programme could work better. In any case, the result seems to be quite good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vivadavid @fire-eggs