Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade RAR support for WinRAR "RAR5" format #78

Closed
NeverSm1le opened this issue Oct 19, 2023 · 8 comments
Closed

Upgrade RAR support for WinRAR "RAR5" format #78

NeverSm1le opened this issue Oct 19, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@NeverSm1le
Copy link

Thumbnails generation works perfectly on png/jpg but not webp or avif contained in archive. Hope you can add support in the next update.

@fire-eggs
Copy link
Owner

Please see issue #49.

@NeverSm1le
Copy link
Author

Thank you for your help but it still doesn't work, guess it's the problem with webp in general.

@fire-eggs
Copy link
Owner

If you could let me have a copy of the book(s) showing the problems I could dig further.

@NeverSm1le
Copy link
Author

NeverSm1le commented Oct 21, 2023

Upon further investigation, the same webp files worked in a .zip but not in a .rar. Here's a copy of both files, hope you can shed some more light on this. I used Windows 10, Winrar 6.23 is used to compress both files.

https://drive.google.com/drive/folders/1opXnT51-Z-aCbgiK4Q_VOR4zCmGaaTO1?usp=share_link

@fire-eggs fire-eggs reopened this Oct 21, 2023
@fire-eggs
Copy link
Owner

Thank you!

@fire-eggs fire-eggs added the bug Something isn't working label Oct 21, 2023
@fire-eggs
Copy link
Owner

I took a quick look at the .RAR file. It looks like you found a limitation of the RAR support in DarkThumbs.

DarkThumbs' RAR support is a little old now and doesn't handle the latest RAR5 format produced by WinRAR 5.0 and later. I wasn't aware of this newer format and so updating the RAR code hasn't been a priority. I'll bump it up on the priority list!

The work-around would be to use the "old" RAR format in WinRAR, or use ZIP.

[ I've just determined that my favorite comic reader doesn't handle that RAR5 archive either! I'll have to let them know! ]

Thanks again!

@fire-eggs fire-eggs changed the title Support for more image format? Upgrade RAR support for WinRAR "RAR5" format Oct 21, 2023
@13xforever
Copy link

New versions of WinRAR dropped support for legacy format, all newly created archives are using the new rar5 format, so it might be a good idea to revisit this issue.

fire-eggs added a commit that referenced this issue Apr 24, 2024
…BP or other codec-required image formats didn't work for RAR files. Note: extra work required for 'problem_cbr' files support.
@fire-eggs
Copy link
Owner

DarkThumbs V1.8 has been updated with the latest WinRAR code to support RAR5.

I also fixed a problem where image formats (such as WEBP) which required a Windows codec would not work with RAR files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants