Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading Logcat error when using custom layout for FirebaseUI Auth #1688

Closed
AhmedAshour opened this issue Sep 23, 2019 · 2 comments
Closed

Comments

@AhmedAshour
Copy link

  • FirebaseUI version: 6.0.2

Problem Description:
When creating an AuthMethodPickerLayout object to make a custom layout for the login screen,
you have to set button ids of the auth providers that you chose.
When you choose EmailBuilder as a provider but without providing a button id for it while creating the AuthMethodPickerLayout object the app crashes and shows this error in log cat:
Caused by: java.lang.IllegalStateException: No button found for auth provider: password

So the problem here is the "password" word, it should say "email" or "EmailBuilder."

I thought that this could be misleading to some people so I created this issue.

Steps to reproduce:

  1. Create an AuthMethodPickerLayout object to make a custom layout.
  2. Choose EmailBuilder as a provider but without providing a button id for it while creating the object.

Observed Results:

Caused by: java.lang.IllegalStateException: No button found for auth provider: password

Expected Results:

Caused by: java.lang.IllegalStateException: No button found for auth provider: email

@samtstern
Copy link
Contributor

@AhmedAshour thanks for filing this! That's a reasonable request, I'll look into it for the next version.

@samtstern
Copy link
Contributor

The fix for this issue has been released in version 6.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants