Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publicly usable lint checks #1427

Merged
merged 3 commits into from Sep 4, 2018
Merged

Publicly usable lint checks #1427

merged 3 commits into from Sep 4, 2018

Conversation

samtstern
Copy link
Contributor

See #1351

I wonder if we should create an empty firebaseui-lint android library that only exists to have the lintChecks call. I say that because I am not sure what happens if we had multiple (for example auth and firestore) depending on the lint module as lintChecks

@samtstern samtstern added this to the 4.2.0 milestone Aug 29, 2018
@samtstern
Copy link
Contributor Author

cc @pavlospt wdyt?

@samtstern
Copy link
Contributor Author

This is failing because #1426 is not yet merged.

@samtstern
Initial Commit
58b8335 
Change-Id: I9b712f3df3e1a164867f69abb9e7f3270f48195f
@samtstern
Kotlin import error
9f5c463 
Change-Id: I5076201bc6d5ec7196a229485af91f4c894eca5c
@samtstern
Copy link
Contributor Author

Remaining error:

Errors found:
  
  /usr/local/google/home/samstern/Projects/firebase/firebaseui-android/auth/src/main/res/values/com_crashlytics_export_strings.xml:9: Error: Resource named 'com.crashlytics.android.build_id' does not start with the project's resource prefix 'fui_'; rename to 'fui_com.crashlytics.android.build_id' ? [ResourceName]
      <string tools:ignore="UnusedResources,TypographyDashes" name="com.crashlytics.android.build_id" translatable="false">77252c51-646a-4395-affc-28655847aec9</string>

I know we hit this before but I forget why.

@pavlospt
Copy link
Contributor

If there was a firebaseui-lint library it could be served as a dependency as well for standalone usage! Otherwise the separation looks good to me!

SUPERCILEX
SUPERCILEX approved these changes Sep 3, 2018
View reviewed changes
Copy link
Collaborator

@SUPERCILEX SUPERCILEX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, LGTM! 👍

proguard-tests/build.gradle.kts
@@ -4,6 +4,14 @@ android {
}

buildTypes {
named("debug").configure {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why'd we add this back? It adds like 5+ mins to a full debug build. Shouldn't we only run it in CI?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh damn I forgot why we removed it. Android Studio gets pretty angry when not all modules have matching configurations and this made it happy.

Let me see if I can appease Android Studio without compromising time.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh, yeah, I remember seeing those warnings. Let's use a variant filter then: https://developer.android.com/studio/build/build-variants#filter-variants

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep it looks like that's already working with setIgnore. I pushed a commit to simplify the debug config to the minimum that makes AS happy.

I did a time of some clean builds and the extra config doesn't cost us anything. Will confirm via Travis logs.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, SGTM!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis confirmed: no slowdown.

@samtstern
Simplify debug config
d58326d 
Change-Id: I561c1183fa383f51d9117ec870303cf767e9b641
@samtstern samtstern merged commit 8949483 into version-4.2.0-dev Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SUPERCILEX SUPERCILEX SUPERCILEX approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@samtstern @pavlospt @SUPERCILEX