return the $id of the added object when calling add() on angularFireCollection #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd be okay with the ref, too. But that seems a bit like mixing metaphors to me. Still, that would work for my purposes. Here's an example of code that uses it: https://github.com/binaryfeed/tictactoe-angularjs-firebase |
|
+1 this is a much needed feature. |
|
+1 |
1 similar comment
|
+1 |
|
Fixed in bfb831c We return the ref of the object when you call angularFireCollection.add(). You can access the ID of the object via ref.name(). |
|
Yes!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR: Bring the semantics of angularFireCollection.add() a bit closer to that of Firebase.push().
This change set allows you to reference the added object by it's uniquely-generated (by Firebase) $id. This can be useful, for example, if one controller adds a new object and then passes control to another controller that wants to pull that object out of firebase using its $id.