-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faster, more consistent tests #740
Conversation
@jwngr Ptal - removed a couple uneeded tests, fixed the rest and sped everything up. |
}); | ||
|
||
it('only removes keys in query when query is used', function(done){ | ||
return ref.set(MOCK_DATA).then(function() { | ||
tick(); | ||
// tick(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call ☎️
Looks good to me although I think @katowulf has a better grasp on the digest loop stuff than I do. Tying it into our |
Actually, Abe, I'm thinking your commit song should be this one. |
@@ -114,14 +116,19 @@ describe('Todo App', function () { | |||
}); | |||
return def.promise; | |||
}).then(function () { | |||
expect(todos.count()).toBe(6); | |||
browser.wait(function() { | |||
return element(by.id('todo-4')).isPresent() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀
🔥🔥🔥
lgtm! Jacob and I both made minor nits. Decide if you want to address those and send it back my way to merge. |
Back to you Mr. W |
Zoom, zoom, zoom.
https://www.youtube.com/watch?v=O0ikW7pVa_I