Faster, more consistent tests #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abeisgoat
changed the title
|
@jwngr Ptal - removed a couple uneeded tests, fixed the rest and sped everything up. |
| }); | ||
|
|
||
| it('only removes keys in query when query is used', function(done){ | ||
| return ref.set(MOCK_DATA).then(function() { | ||
| tick(); | ||
| // tick(); |
|
Looks good to me although I think @katowulf has a better grasp on the digest loop stuff than I do. Tying it into our |
|
Actually, Abe, I'm thinking your commit song should be this one. |
| @@ -114,14 +116,19 @@ describe('Todo App', function () { | |||
| }); | |||
| return def.promise; | |||
| }).then(function () { | |||
| expect(todos.count()).toBe(6); | |||
| browser.wait(function() { | |||
| return element(by.id('todo-4')).isPresent() | |||
|
lgtm! Jacob and I both made minor nits. Decide if you want to address those and send it back my way to merge. |
|
Back to you Mr. W |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zoom, zoom, zoom.
https://www.youtube.com/watch?v=O0ikW7pVa_I