fix(modules): Separate AngularFire services into modules #841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davideast
changed the title
|
LGTM! |
|
🐐 |
This was referenced Aug 16, 2016
| angular.module("firebase", ["firebase.utils", "firebase.config", "firebase.auth", "firebase.database"]) | ||
| //TODO: use $window | ||
| .value("Firebase", exports.firebase) |
There was a problem hiding this comment.
Why are we still exporting Firebase with a capital "F"? This should not be required anymore.
There was a problem hiding this comment.
If we removed this it would be a breaking change which we're avoiding here.
There was a problem hiding this comment.
Makes sense. Let's at least add a TODO comment here to remove this line when the 3.0.0 release happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modularizes internal shenanigans