lint before legacy build, show firebase comment in legacy build

plus other review comment changes

.jshintrc

@@ -3,7 +3,6 @@
     "document",
     "window",
     "-Promise",
-    "Firebase",
     "moment",
     "md5"
   ],
@@ -31,5 +30,7 @@
   "white": false,
   "eqnull": true,
   "esnext": true,
-  "unused": true
+  "unused": "vars",
+  "smarttabs": true,
+  "bitwise": false
 }

.npmignore

@@ -9,4 +9,5 @@ tests/
 **/.gitkeep
 bower.json
 Brocfile.js
+gulpfile.js
 testem.json

addon/adapters/firebase.js

@@ -273,18 +273,18 @@ export default DS.Adapter.extend(Ember.Evented, {
       record.eachRelationship(function(key, relationship) {
         var save;
         if (relationship.kind === 'hasMany') {
-            if (serializedRecord[key]) {
-              save = adapter._saveHasManyRelationship(store, type, relationship, serializedRecord[key], recordRef, recordCache);
-              savedRelationships.push(save);
-              // Remove the relationship from the serializedRecord because otherwise we would clobber the entire hasMany
-              delete serializedRecord[key];
-            }
+          if (serializedRecord[key]) {
+            save = adapter._saveHasManyRelationship(store, type, relationship, serializedRecord[key], recordRef, recordCache);
+            savedRelationships.push(save);
+            // Remove the relationship from the serializedRecord because otherwise we would clobber the entire hasMany
+            delete serializedRecord[key];
+          }
         } else {
-            if (relationship.options.embedded === true && serializedRecord[key]) {
-              save = adapter._saveBelongsToRecord(store, type, relationship, serializedRecord[key], recordRef);
-              savedRelationships.push(save);
-              delete serializedRecord[key];
-            }
+          if (relationship.options.embedded === true && serializedRecord[key]) {
+            save = adapter._saveBelongsToRecord(store, type, relationship, serializedRecord[key], recordRef);
+            savedRelationships.push(save);
+            delete serializedRecord[key];
+          }
         }
       });
 

gulpfile.js

@@ -6,6 +6,13 @@ var sourcemaps = require('gulp-sourcemaps');
 var transpile  = require('gulp-es6-module-transpiler');
 var concat = require('gulp-concat');
 var uglify = require('gulp-uglify');
+var jshint = require('gulp-jshint');
+
+gulp.task('lint', function () {
+  return gulp.src('{addon,app,blueprints,config,tests}/**/*.js')
+    .pipe(jshint())
+    .pipe(jshint.reporter('default'));
+});
 
 gulp.task('clean-dist', function (cb) {
   del([
@@ -14,7 +21,7 @@ gulp.task('clean-dist', function (cb) {
   ], cb);
 });
 
-gulp.task('build-legacy', function() {
+gulp.task('build-legacy', ['lint'], function() {
   return gulp.src('vendor/legacy-shims/emberfire.js')
     .pipe(sourcemaps.init())
     .pipe(transpile({
@@ -26,14 +33,16 @@ gulp.task('build-legacy', function() {
     .pipe(gulp.dest('dist'));
 });
 
-gulp.task('build-legacy-minified', function() {
+gulp.task('build-legacy-minified', ['lint'], function() {
   return gulp.src('vendor/legacy-shims/emberfire.js')
     .pipe(transpile({
       importPaths: ['vendor/legacy-shims'], // for 'ember' and 'ember-data' global shims
       formatter: 'bundle'
     }))
     .pipe(concat('emberfire.min.js'))
-    .pipe(uglify())
+    .pipe(uglify({
+      preserveComments: 'some'
+    }))
     .pipe(gulp.dest('dist'));
 });
 

package.json

@@ -54,6 +54,7 @@
     "gulp": "^3.8.11",
     "gulp-concat": "^2.5.1",
     "gulp-es6-module-transpiler": "^0.2.1",
+    "gulp-jshint": "^1.9.2",
     "gulp-sourcemaps": "^1.3.0",
     "gulp-uglify": "^1.1.0"
   }

vendor/legacy-shims/emberfire.js

@@ -1,3 +1,8 @@
+import Ember from 'ember';
+import FirebaseAdapter from '../../addon/adapters/firebase';
+import FirebaseSerializer from '../../addon/serializers/firebase';
+import EmberFireInitializer from '../../addon/initializers/emberfire';
+
 /*!
  * EmberFire is the officially supported adapter for using Firebase with
  * Ember Data. The DS.FirebaseAdapter provides all of the standard DS.Adapter
@@ -7,12 +12,6 @@
  * https://github.com/firebase/emberfire/
  * License: MIT
  */
-
-import Ember from 'ember';
-import FirebaseAdapter from '../../addon/adapters/firebase';
-import FirebaseSerializer from '../../addon/serializers/firebase';
-import EmberFireInitializer from '../../addon/initializers/emberfire';
-
 window.DS.FirebaseAdapter = FirebaseAdapter;
 window.DS.FirebaseSerializer = FirebaseSerializer;