Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error on cold start firestore-send-email #48

Closed
rphlmr opened this issue Oct 16, 2019 · 9 comments
Closed

Error on cold start firestore-send-email #48

rphlmr opened this issue Oct 16, 2019 · 9 comments
Assignees

Comments

@rphlmr
Copy link

rphlmr commented Oct 16, 2019

[READ] Step 1: Are you in the right place?

Issues filed here should be about bugs for a specific extension in this repository.
If you have a general question, need help debugging, or fall into some
other category use one of these other channels:

  • For general technical questions, post a question on StackOverflow
    with the firebase tag.
  • For general Firebase discussion, use the firebase-talk
    google group.
  • To file a bug against the Firebase Extensions platform, or for an issue affecting multiple extensions, please reach out to
    Firebase support directly.

[REQUIRED] Step 2: Describe your configuration

  • Extension name: firestore-send-email
  • Configuration values (redact info where appropriate):
    • all config require (extension is working, except after a cold start)

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

firestore-send-email throw an unhandled error at cold start :

Unhandled error occurred during processing: { Error
    at Http2CallStream.call.on (/srv/node_modules/@grpc/grpc-js/build/src/client.js:96:45)
    at emitOne (events.js:121:20)
    at Http2CallStream.emit (events.js:211:7)
    at process.nextTick (/srv/node_modules/@grpc/grpc-js/build/src/call-stream.js:71:22)
    at _combinedTickCallback (internal/process/next_tick.js:132:7)
    at process._tickDomainCallback (internal/process/next_tick.js:219:9)
  code: 13,
  details: '',
  metadata: Metadata { options: undefined, internalRepr: Map {} },
  note: 'Exception occurred in retry method that was not classified as transient' }
Expected result

Mail send / or send retry

Actual result

Mail not sent and not retried

@Ehesp
Copy link
Member

Ehesp commented Oct 16, 2019

Thanks for the report! @laurenzlong would you be able to help take a look at this?

@rphlmr
Copy link
Author

rphlmr commented Oct 16, 2019

I think it'll be linked to firebase/firebase-functions#536

A problem in the grpc implementation.

In my own functions I have the same problem and I rollback dependencies to :

"firebase-admin": "7.4.0",
"firebase-functions": "2.3.1"

@laurenzlong
Copy link
Contributor

Thanks for the helpful issue link @rphlmr! The best course of action is to implement the suggestion in firebase/firebase-functions#536 (comment). I confirmed with Sebastian, author of that comment, who works on Firestore, and he confirmed that was the most reliable thing to do at the moment. This bug also affects not just firestore-send-email, but other extensions that write to Firestore also. I'll make a PR for this.

@rphlmr
Copy link
Author

rphlmr commented Oct 23, 2019

Hi :)
Thanks for the PR.
I have a stupid question, excuse me, but do we'll receive an email when updates are released ?
Or where will you publish patch notes ?

@laurenzlong
Copy link
Contributor

Hi @rphlmr if you would like to be informed of new releases, you can click the "watch" button at the top right corner of this page, and then select "releases only".

@rphlmr
Copy link
Author

rphlmr commented Nov 7, 2019

Thanks everyone for the 0.1.1 ;)

@laurenzlong
Copy link
Contributor

You're welcome! Thanks for reporting!

@licalac
Copy link

licalac commented Jan 20, 2020

Hi everyone,

I'm using Trigger mail Version 0.1.2 and just have same issue today ...

Unhandled error occurred during processing: { Error
    at Http2CallStream.call.on (/srv/node_modules/@grpc/grpc-js/build/src/client.js:96:45)
    at emitOne (events.js:121:20)
    at Http2CallStream.emit (events.js:211:7)
    at process.nextTick (/srv/node_modules/@grpc/grpc-js/build/src/call-stream.js:71:22)
    at _combinedTickCallback (internal/process/next_tick.js:132:7)
    at process._tickDomainCallback (internal/process/next_tick.js:219:9)
  code: 13,
  details: '',
  metadata: Metadata { options: undefined, internalRepr: Map {} },
  note: 'Exception occurred in retry method that was not classified as transient' }

that was not supposed to be fixed since November on version 0.1.1 ?

@fgatti675
Copy link

fgatti675 commented Jan 22, 2020

Got the same with 0.1.2:

Unhandled error occurred during processing: { Error
    at Http2CallStream.call.on (/srv/node_modules/@grpc/grpc-js/build/src/client.js:96:45)
    at emitOne (events.js:121:20)
    at Http2CallStream.emit (events.js:211:7)
    at process.nextTick (/srv/node_modules/@grpc/grpc-js/build/src/call-stream.js:71:22)
    at _combinedTickCallback (internal/process/next_tick.js:132:7)
    at process._tickDomainCallback (internal/process/next_tick.js:219:9)
  code: 13,
  details: '',
  metadata: Metadata { options: undefined, internalRepr: Map {} },
  note: 'Exception occurred in retry method that was not classified as transient' }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants