firestore-send-email sets document state to PROCESSING indefinitely

[bdiz]

[REQUIRED] Step 2: Describe your configuration

• Extension name: firestore-send-email
• Extension version: v0.1.7
• Configuration values (redact info where appropriate):
  • Cloud Functions location: us-central1
  • SMTP connection URI: smtp://<POSTMARK_API_TOKEN>:<POSTMARK_API_TOKEN>@smtp.postmarkapp.com:25
  • Email documents collection: emails
  • Default FROM address: User user@example.com
  • Default REPLY-TO address (Optional): Parameter not set
  • Users collection (Optional): users
  • Templates collection (Optional): emailTemplates

[REQUIRED] Step 3: Describe the problem

Steps to reproduce:

When adding a document to my emails collection, I am getting an indefinite state of PROCESSING.

Expected result

Expected the state to move beyond PROCESSING and send the mail.

Actual result

The document persists in the following state indefinitely.

createdAt: January 23, 2021 at 8:59:40 AM UTC-6
delivery:
  attempts: 0
  error: null
  leaseExpireTime: January 23, 2021 at 9:00:45 AM UTC-6
  startTime: January 23, 2021 at 8:59:44 AM UTC-6
  state: "PROCESSING"
from: "Ben Example <user@example.com>"
message:
  subject: "Example subject"
  text: "Example message"
private: true
replyTo: "ben.example@gmail.com"
toUids:
  0: "HkKeaL2MxJZkymy3g89OIBDDaYH3"
userId: "HkKeaL2MxJZkymy3g89OIBDDaYH3"

Details:

I am using Postmark. My smtp URI looks like smtp://<POSTMARK_API_TOKEN>:<POSTMARK_API_TOKEN>@smtp.postmarkapp.com:25. Postmark uses an API key with only hex characters and dashes so special characters doesn't seem like it would be the issue. The username and password for postmark are the same, the API token.

Debug:

I tried this smtp URI with nodemailer in a node repl locally and I was able to send an email successfully so it doesn't seem to be the Postmark smtp URI.

I also dug into the extensions code a little bit. In the extension, upon the create of the initial document, the cloud function updates attempts to 0 and state to PENDING. But what I see when observing the document in the firebase console is attempts are 0 and state is PROCESSING.

Looking at the switch statement for PENDING, it sets state to PROCESSING and then should call deliver().

extensions/firestore-send-email/functions/src/index.ts

Lines 325 to 337 in 3aa9fd5

	case "PENDING":
	case "RETRY":
	// Wrapping in transaction to allow for automatic retries (#48)
	await admin.firestore().runTransaction((transaction) => {
	transaction.update(change.after.ref, {
	"delivery.state": "PROCESSING",
	"delivery.leaseExpireTime": admin.firestore.Timestamp.fromMillis(
	Date.now() + 60000
	),
	});
	return Promise.resolve();
	});
	return deliver(payload, change.after.ref);

However, if deliver() was called at all, why would attempts remain 0? My logs confirm that the "Attempting delivery..." message is not present either.

Is there something with await admin.firestore().runTransaction where it might be hanging there (though update of state to PROCESSING goes through)? I see there is a comment in the code about issue #48. Not sure if the issues there are still causing issues with this firebase extension.

[dackers86]

Hi @bdiz

Can you confirm there are no errors in your logs for the extensions?

Additionally, I noticed that your protocol is smtp, does this work with smtps?

[bdiz]

Hi @dackers86

No function errors (just infos and debug messages), but the last two messages are noteworthy. Providing all messages for your reference.

Using smtps instead of smtp the result is identical so far as I can tell by comparing the function logs and contents of the email document (ie. state is also PROCESSING).

[russellwheatley]

Hey @bdiz, have you tried port 587 yet? That is the typical port for smtp protocol from email client to email server.

[bdiz]

Hi @russellwheatley , with smtp and 587 it finished with SUCCESS and I received the email. Thank you.

I'll notify Postmark support of this issue, as they believe port 25 should work.

Also, as I mentioned previously it does work on port 25 when sent via nodemailer in a node REPL. I'm wondering if there is an enhancement that could get it working in this extension, and at a minimum provide better debug messages vs timing out in the PROCESSING state.

Thank you for looking this over and providing these suggestions.

[briankerr]

Hello, chiming in from Postmark's support perspective 👋

We offer ports 25 , 2525, and 587 for outbound SMTP. This could suggest that Firebase started blocking port 25. Blocking that port is pretty common as an anti-abuse measure for a host.

I couldn't find a blocked port list in Firebase's docs, but I see that Google Computer Engine blocks port 25 so it wouldn't surprise me if they started to use a similar rule here.

[russellwheatley]

Thanks for the feedback, folks. Glad it worked @bdiz. What @briankerr said sounds correct to me. The Firebase cloud functions are using Google Cloud Platform so it is safe to assume that port 25 is simply being blocked.

[bdiz]

@russellwheatley Can extension error be updated to indicate blocked ports? At a minimum can the extension docs be updated with this info?

…

On Wed, Jan 27, 2021, 3:13 AM Russell Wheatley ***@***.***> wrote: Thanks for the feedback, folks. Glad it worked @bdiz <https://github.com/bdiz>. What @briankerr <https://github.com/briankerr> said sounds correct to me. The Firebase cloud functions are using Google Cloud Platform so it is safe to assume that port 25 is simply being blocked. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#574 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHGWOWA7UOZXL2R7ZXZHD3S37KL5ANCNFSM4WPYWO2Q> .

[russellwheatley]

That makes sense to me. We should probably update the docs to inform users.

[dackers86]

Initial PR added at #582