feat(storage-resize-images): put failed resizes in a separate directory #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabljac
force-pushed
the
@invertase/resize-failed-directory
branch
3 times, most recently
from
11e72a1
to
27808d8
Compare
|
needs specific tests adding |
cabljac
force-pushed
the
@invertase/resize-failed-directory
branch
3 times, most recently
from
78ae82b
to
3b56934
Compare
cabljac
force-pushed
the
@invertase/resize-failed-directory
branch
from
3b56934
to
06ba7a1
Compare
cabljac
force-pushed
the
@invertase/resize-failed-directory
branch
from
06ba7a1
to
f0a075e
Compare
dackers86
reviewed
Jan 9, 2023
dackers86
approved these changes
Jan 10, 2023
Extension Update Tracker
automation
moved this from In review
to Launch approval pending
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #563
Note
If the extension is configured to generate multiple sizes, the image will be copied to the failed folder even if only one size fails