Replace deprecated String.prototype.substr() #1376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabljac
force-pushed
the
@invertase/replace-substr
branch
from
7edc3a1
to
9e74beb
Compare
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated Signed-off-by: Tobias Speicher <rootcommander@gmail.com>
cabljac
force-pushed
the
@invertase/replace-substr
branch
from
9e74beb
to
6bfa08e
Compare
dackers86
approved these changes
Mar 6, 2023
Extension Update Tracker
automation
moved this from In review
to Launch approval pending
Mar 6, 2023
Extension Update Tracker
automation
moved this from Launch approval pending
to Launched
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(reopening #928 for testing purposes)
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated