Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented CustomUserClaims #17

Merged
merged 14 commits into from Jan 23, 2019

Conversation

@dominikfoldi
Copy link
Contributor

commented Jan 11, 2019

I have implemented the Custom User Claims feature. I do not checked out the contributing guidelines yet but I want to get feedback from you about my changes. I will implement the tests after everything else looks good.

My main guideline was the Java SDK.

@hiranya911 could you please check this out?

@dominikfoldi dominikfoldi changed the title Implement CustomUserClaims Implemented CustomUserClaims Jan 11, 2019

@googlebot

This comment has been minimized.

Copy link

commented Jan 11, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
@hiranya911
Copy link
Member

left a comment

Thanks for doing this @dominikfoldi. I think you have all the basic elements. The details need a bit of polishing.

@hiranya911 hiranya911 self-assigned this Jan 11, 2019

@dominikfoldi dominikfoldi force-pushed the tekrama:feature-custom-claims branch from 0371ae8 to 7d98076 Jan 13, 2019

@googlebot

This comment has been minimized.

Copy link

commented Jan 13, 2019

CLAs look good, thanks!

@hiranya911
Copy link
Member

left a comment

Thanks @dominikfoldi. This is looking pretty good. I've pointed out few changes. While you're working on them. I'm going to start our internal API review process for this, so we can get it merged and released soon.

dominikfoldi added some commits Jan 15, 2019

Make FirebaseUserManager constructor internal to be able to use it in…
… tests and add error handling if the response of the update API contains incorrect data
Remove SetCustomUserClaimsInvalidCredential from FirebaseAuthTest, re…
…moved unused parts of the tests, simplify claims initialization for TooLargeClaimsPayload test and introduced unit tests for UpdateUserAsync by mocking the httpclient
@dominikfoldi

This comment has been minimized.

Copy link
Contributor Author

commented Jan 15, 2019

@hiranya911 I think I am resolved all your requests. Thanks to you I found a bug in the FirebaseUserManager's PostAsync method when the server responds with empty uid, I don't know if could ever happen but I covered that just in case.

@hiranya911
Copy link
Member

left a comment

Just 2 more comments. I also have submitted this API for internal review. I should hear back in a couple of days. Hopefully we can get this released next week.

@hiranya911
Copy link
Member

left a comment

LGTM. Waiting API review approval for merge.

@dominikfoldi

This comment has been minimized.

Copy link
Contributor Author

commented Jan 17, 2019

Thank you for this super fast process! Looking forward to it!

@hiranya911 hiranya911 merged commit 88bcb1b into firebase:master Jan 23, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hiranya911

This comment has been minimized.

Copy link
Member

commented Jan 24, 2019

@dominikfoldi this is released: https://firebase.google.com/support/release-notes/admin/dotnet#1.1.0

Hope you continue to contribute.

@dominikfoldi

This comment has been minimized.

Copy link
Contributor Author

commented Jan 24, 2019

@hiranya911 thank you for the release!

Our next step is to integrate Firebase Authentication into our project. But after I am sure that I will contribute more!

@dominikfoldi dominikfoldi deleted the tekrama:feature-custom-claims branch Jan 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.