Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: multicast messaging #36

Merged
merged 7 commits into from Mar 26, 2019

Conversation

@kentcb
Copy link
Contributor

commented Mar 21, 2019

Add support for multicast/send-all messaging.

kentcb added some commits Mar 21, 2019

@kentcb kentcb force-pushed the kentcb:multicastmessaging branch 2 times, most recently from a855e2b to 81a4a5e Mar 22, 2019

@kentcb kentcb force-pushed the kentcb:multicastmessaging branch from 81a4a5e to ec7d7d4 Mar 22, 2019

@kentcb kentcb marked this pull request as ready for review Mar 22, 2019

@kentcb

This comment has been minimized.

Copy link
Contributor Author

commented Mar 22, 2019

@hiranya911 Ready for review.

@hiranya911

This comment has been minimized.

Copy link
Member

commented Mar 22, 2019

Thank you @kentcb. Love what you've done here. I will take a closer look tomorrow morning. If all goes well I think we can release this next week (this API was already proposed and approved at the same time I worked on the Node and Java implementations).

@hiranya911 hiranya911 self-assigned this Mar 22, 2019

@hiranya911
Copy link
Member

left a comment

Thanks again @kentcb for putting this together. Really appreciate you putting in the effort to provide a PR complete with unit and integration tests. I've pointed out a few things that should be changed. I think most of them are minor nits. The areas that need most work are:

  1. Validating message list in FirebaseMessagingClient
  2. Changing how MulticastMessage is unit tested

Please let me know if you have any questions.

@kentcb

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

@hiranya911 Thanks very much for the review. I've pushed fixes based on your comments.

@hiranya911
Copy link
Member

left a comment

Thanks again @kentcb. I think we're almost there. Just a few more changes to make. My two big feedback points are on the public API surface:

  1. What is currently called SendResponse should be called BatchResponse.
  2. What is currently called SendItemResponse should be called SendResponse.

Sorry, if it wasn't clear from my earlier comments.

@kentcb

This comment has been minimized.

Copy link
Contributor Author

commented Mar 25, 2019

@hiranya911 Ah, my bad. OK, I've fixed that as well as the other items you pointed out.

@hiranya911
Copy link
Member

left a comment

Thanks. LGTM 👍

I'll try to publish a release in a couple of days.

@hiranya911 hiranya911 merged commit ae0d725 into firebase:master Mar 26, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.