Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(auth): Migrate IAM SignBlob to IAMCredentials SignBlob #404

Merged
merged 3 commits into from
Sep 30, 2020

Conversation

kentengjin
Copy link
Contributor

@kentengjin kentengjin commented Sep 30, 2020

Point all SignBlob to iamcredentials instead of iam.

RELEASE NOTE: Migrated the token signing functionality to the new IAM credentials API.

Point all SignBlob to iamcredentials instead of iam
Correct and format some contents
@kentengjin kentengjin marked this pull request as ready for review September 30, 2020 20:39
@kentengjin kentengjin changed the title Migrate IAM SignBlob to IAMCredentials SignBlob fix(auth): Migrate IAM SignBlob to IAMCredentials SignBlob Sep 30, 2020
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hiranya911 hiranya911 self-assigned this Sep 30, 2020
@hiranya911 hiranya911 merged commit 3d5e560 into firebase:dev Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants