Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add given httpTransport in GooglePublicKeysManager #151

Merged
merged 1 commit into from Mar 9, 2018

Conversation

@xbauquet
Copy link
Contributor

commented Mar 9, 2018

Construct the default GooglePublicKeysManager with the custom
httpTransport. This avoid error due to proxy.
Fixes #150

Add given httpTransport in GooglePublicKeysManager
Construct the default GooglePublicKeysManager with the custom
httpTransport. This avoid error due to proxy.
Fixes #150
@googlebot

This comment has been minimized.

Copy link

commented Mar 9, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
  • Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
  • The email used to register you as an authorized contributor must also be attached to your GitHub account.
@xbauquet

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2018

I signed it!

@googlebot

This comment has been minimized.

Copy link

commented Mar 9, 2018

CLAs look good, thanks!

@hiranya911
Copy link
Member

left a comment

LGTM 👍

Thanks @xbauquet for the contribution.

@hiranya911 hiranya911 self-assigned this Mar 9, 2018

@hiranya911 hiranya911 merged commit aca5fcc into firebase:master Mar 9, 2018

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@quackes

This comment has been minimized.

Copy link

commented Apr 12, 2018

Hi,
when will this be released?

@hiranya911

This comment has been minimized.

Copy link
Member

commented Apr 12, 2018

I'll try to find some time next week to stage a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.